2020-10-02 10:18:08

by Colin King

[permalink] [raw]
Subject: [PATCH][next] media: zoran: fix spelling mistake and make error message more meaningful

From: Colin Ian King <[email protected]>

There is a spelling mistake in a pci_err error message. Fix this and
make the error message a little more meaningful.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/staging/media/zoran/zoran_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
index 808196ea5b81..d9f8b21edf6a 100644
--- a/drivers/staging/media/zoran/zoran_driver.c
+++ b/drivers/staging/media/zoran/zoran_driver.c
@@ -666,7 +666,7 @@ static int zoran_g_selection(struct file *file, void *__fh, struct v4l2_selectio

if (sel->type != V4L2_BUF_TYPE_VIDEO_OUTPUT &&
sel->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) {
- pci_err(zr->pci_dev, "%s invalid combinaison\n", __func__);
+ pci_err(zr->pci_dev, "%s invalid selection type combination\n", __func__);
return -EINVAL;
}

--
2.27.0


2020-10-05 10:56:11

by Corentin LABBE

[permalink] [raw]
Subject: Re: [PATCH][next] media: zoran: fix spelling mistake and make error message more meaningful

On Fri, Oct 02, 2020 at 11:16:20AM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> There is a spelling mistake in a pci_err error message. Fix this and
> make the error message a little more meaningful.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/staging/media/zoran/zoran_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> index 808196ea5b81..d9f8b21edf6a 100644
> --- a/drivers/staging/media/zoran/zoran_driver.c
> +++ b/drivers/staging/media/zoran/zoran_driver.c
> @@ -666,7 +666,7 @@ static int zoran_g_selection(struct file *file, void *__fh, struct v4l2_selectio
>
> if (sel->type != V4L2_BUF_TYPE_VIDEO_OUTPUT &&
> sel->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) {
> - pci_err(zr->pci_dev, "%s invalid combinaison\n", __func__);
> + pci_err(zr->pci_dev, "%s invalid selection type combination\n", __func__);
> return -EINVAL;
> }
>
> --
> 2.27.0
>

Hello

Acked-by: Corentin Labbe <[email protected]>

Thanks