2020-10-03 14:23:38

by Sumera Priyadarsini

[permalink] [raw]
Subject: [PATCH] scripts: coccicheck: Refactor display messages on coccinelle start up

Currently, coccinelle starts by printing
"When using "patch" mode, carefully review the
patch before submitting it."

Modify coccicheck to print this message only when the user has
explicitly selected "patch" or "chain" mode.

Signed-off-by: Sumera Priyadarsini <[email protected]>
---
scripts/coccicheck | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/coccicheck b/scripts/coccicheck
index e04d328210ac..07d1b5831bf6 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -118,7 +118,9 @@ fi
if [ "$ONLINE" = "0" ] ; then
echo ''
echo 'Please check for false positives in the output before submitting a patch.'
- echo 'When using "patch" mode, carefully review the patch before submitting it.'
+ if [ "$MODE" = "patch" -o "$MODE" = "chain" ] ; then
+ echo 'When using "patch" mode, carefully review the patch before submitting it.'
+ fi
echo ''
fi

--
2.25.1