2020-10-05 13:00:43

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] i2c: mlxbf: I2C_MLXBF should depend on MELLANOX_PLATFORM

The Mellanox BlueField I2C controller is only present on Mellanox
BlueField SoCs. Hence add a dependency on MELLANOX_PLATFORM, to prevent
asking the user about this driver when configuring a kernel without
Mellanox platform support.

Fixes: b5b5b32081cd206b ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/i2c/busses/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 96685b273f637176..424dee8b33600057 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -732,7 +732,7 @@ config I2C_LPC2K

config I2C_MLXBF
tristate "Mellanox BlueField I2C controller"
- depends on ARM64
+ depends on MELLANOX_PLATFORM && ARM64
help
Enabling this option will add I2C SMBus support for Mellanox BlueField
system.
--
2.17.1


2020-10-10 23:10:36

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: mlxbf: I2C_MLXBF should depend on MELLANOX_PLATFORM

On Mon, Oct 05, 2020 at 02:49:49PM +0200, Geert Uytterhoeven wrote:
> The Mellanox BlueField I2C controller is only present on Mellanox
> BlueField SoCs. Hence add a dependency on MELLANOX_PLATFORM, to prevent
> asking the user about this driver when configuring a kernel without
> Mellanox platform support.
>
> Fixes: b5b5b32081cd206b ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Usually, I wait for maintainer acks before I apply driver patches. I
make an exception here to have it sorted out before the merge window.

Applied to for-next, thanks!

Attachments:
(No filename) (646.00 B)
 signature.asc (849.00 B)
 Download all attachments

2020-11-06 15:00:15

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: mlxbf: I2C_MLXBF should depend on MELLANOX_PLATFORM

On Sat, Oct 10, 2020 at 01:19:42PM +0200, Wolfram Sang wrote:
> On Mon, Oct 05, 2020 at 02:49:49PM +0200, Geert Uytterhoeven wrote:
> > The Mellanox BlueField I2C controller is only present on Mellanox
> > BlueField SoCs. Hence add a dependency on MELLANOX_PLATFORM, to prevent
> > asking the user about this driver when configuring a kernel without
> > Mellanox platform support.
> >
> > Fixes: b5b5b32081cd206b ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
>
> Usually, I wait for maintainer acks before I apply driver patches. I
> make an exception here to have it sorted out before the merge window.
>
> Applied to for-next, thanks!

Strange, this one got missing, too. Applied again to for-current!


Attachments:
(No filename) (806.00 B)
 signature.asc (849.00 B)
 Download all attachments