2020-10-05 13:09:00

by Geert Uytterhoeven

Subject: [PATCH] pinctrl: visconti: PINCTRL_TMPV7700 should depend on ARCH_VISCONTI

The Toshiba Visconti TMPV7700 series pin controller is only present on
Visconti SoCs. Hence add a dependency on ARCH_VISCONTI, to prevent
asking the user about this driver when configuring a kernel without
Visconti platform support.

Fixes: a68a7844264e4fb9 ("pinctrl: visconti: Add Toshiba Visconti SoCs pinctrl support")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/pinctrl/visconti/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/visconti/Kconfig b/drivers/pinctrl/visconti/Kconfig
index 198ec33189cc4706..42653fc60413d203 100644
--- a/drivers/pinctrl/visconti/Kconfig
+++ b/drivers/pinctrl/visconti/Kconfig
@@ -9,6 +9,6 @@ config PINCTRL_VISCONTI
config PINCTRL_TMPV7700
bool "Toshiba Visconti TMPV7700 series pinctrl driver"
depends on OF
- depends on ARM64 || COMPILE_TEST
+ depends on ARCH_VISCONTI || COMPILE_TEST
select PINCTRL_VISCONTI
- default ARM64 && ARCH_VISCONTI
+ default ARCH_VISCONTI
--
2.17.1

2020-10-05 22:38:06

by Nobuhiro Iwamatsu

Subject: Re: [PATCH] pinctrl: visconti: PINCTRL_TMPV7700 should depend on ARCH_VISCONTI

Hi Geert,

On Mon, Oct 05, 2020 at 02:50:49PM +0200, Geert Uytterhoeven wrote:
> The Toshiba Visconti TMPV7700 series pin controller is only present on
> Visconti SoCs. Hence add a dependency on ARCH_VISCONTI, to prevent
> asking the user about this driver when configuring a kernel without
> Visconti platform support.
>
> Fixes: a68a7844264e4fb9 ("pinctrl: visconti: Add Toshiba Visconti SoCs pinctrl support")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Thanks for your fixing.

Acked-by: Nobuhiro Iwamatsu <[email protected]>

Best regards,
Nobuhiro

> ---
> drivers/pinctrl/visconti/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/visconti/Kconfig b/drivers/pinctrl/visconti/Kconfig
> index 198ec33189cc4706..42653fc60413d203 100644
> --- a/drivers/pinctrl/visconti/Kconfig
> +++ b/drivers/pinctrl/visconti/Kconfig
> @@ -9,6 +9,6 @@ config PINCTRL_VISCONTI
> config PINCTRL_TMPV7700
> bool "Toshiba Visconti TMPV7700 series pinctrl driver"
> depends on OF
> - depends on ARM64 || COMPILE_TEST
> + depends on ARCH_VISCONTI || COMPILE_TEST
> select PINCTRL_VISCONTI
> - default ARM64 && ARCH_VISCONTI
> + default ARCH_VISCONTI
> --
> 2.17.1
>
>

2020-10-07 09:52:07

by Linus Walleij

Subject: Re: [PATCH] pinctrl: visconti: PINCTRL_TMPV7700 should depend on ARCH_VISCONTI

On Mon, Oct 5, 2020 at 2:50 PM Geert Uytterhoeven
<[email protected]> wrote:

> The Toshiba Visconti TMPV7700 series pin controller is only present on
> Visconti SoCs. Hence add a dependency on ARCH_VISCONTI, to prevent
> asking the user about this driver when configuring a kernel without
> Visconti platform support.
>
> Fixes: a68a7844264e4fb9 ("pinctrl: visconti: Add Toshiba Visconti SoCs pinctrl support")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Patch applied!

Thanks for fixing this Geert.

Yours,
Linus Walleij