2020-10-07 06:50:21

by Eli Cohen

Subject: [PATCH] vdpa/mlx5: Fix dependency on MLX5_CORE

Remove propmt for selecting MLX5_VDPA by the user and modify
MLX5_VDPA_NET to select MLX5_VDPA. Also modify MLX5_VDPA_NET to depend
on mlx5_core.

This fixes an issue where configuration sets 'y' for MLX5_VDPA_NET while
MLX5_CORE is compiled as a module causing link errors.

Reported-by: kernel test robot <[email protected]>
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 device")s
Signed-off-by: Eli Cohen <[email protected]>
---
drivers/vdpa/Kconfig | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
index a8c7607fdc90..1872dff1d3c6 100644
--- a/drivers/vdpa/Kconfig
+++ b/drivers/vdpa/Kconfig
@@ -29,9 +29,7 @@ config IFCVF
be called ifcvf.

config MLX5_VDPA
- bool "MLX5 VDPA support library for ConnectX devices"
- depends on MLX5_CORE
- default n
+ bool
help
Support library for Mellanox VDPA drivers. Provides code that is
common for all types of VDPA drivers. The following drivers are planned:
@@ -39,7 +37,8 @@ config MLX5_VDPA

config MLX5_VDPA_NET
tristate "vDPA driver for ConnectX devices"
- depends on MLX5_VDPA
+ select MLX5_VDPA
+ depends on MLX5_CORE
default n
help
VDPA network driver for ConnectX6 and newer. Provides offloading
--
2.28.0

2020-10-07 20:18:52

by Saeed Mahameed

Subject: Re: [PATCH] vdpa/mlx5: Fix dependency on MLX5_CORE

On Wed, 2020-10-07 at 09:40 +0300, Eli Cohen wrote:
> Remove propmt for selecting MLX5_VDPA by the user and modify
> MLX5_VDPA_NET to select MLX5_VDPA. Also modify MLX5_VDPA_NET to
> depend
> on mlx5_core.
>
> This fixes an issue where configuration sets 'y' for MLX5_VDPA_NET
> while
> MLX5_CORE is compiled as a module causing link errors.
>
> Reported-by: kernel test robot <[email protected]>
> Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5
> device")s
> Signed-off-by: Eli Cohen <[email protected]>

Reviewed-by: Saeed Mahameed <[email protected]>