2020-09-28 00:43:56

by Baolin Wang

Subject: [PATCH] block: Remove redundant 'return' statement

Remove redundant 'return' statement for 'void' functions.

Signed-off-by: Baolin Wang <[email protected]>
---
block/blk-iocost.c | 2 +-
block/blk-iolatency.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-iocost.c b/block/blk-iocost.c
index ef9476f..e38c406 100644
--- a/block/blk-iocost.c
+++ b/block/blk-iocost.c
@@ -3343,7 +3343,7 @@ static int __init ioc_init(void)

static void __exit ioc_exit(void)
{
- return blkcg_policy_unregister(&blkcg_policy_iocost);
+ blkcg_policy_unregister(&blkcg_policy_iocost);
}

module_init(ioc_init);
diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c
index f90429c..81be009 100644
--- a/block/blk-iolatency.c
+++ b/block/blk-iolatency.c
@@ -1046,7 +1046,7 @@ static int __init iolatency_init(void)

static void __exit iolatency_exit(void)
{
- return blkcg_policy_unregister(&blkcg_policy_iolatency);
+ blkcg_policy_unregister(&blkcg_policy_iolatency);
}

module_init(iolatency_init);
--
1.8.3.1

2020-10-08 03:44:40

by Baolin Wang

Subject: Re: [PATCH] block: Remove redundant 'return' statement

Hi,

On Mon, Sep 28, 2020 at 08:42:26AM +0800, Baolin Wang wrote:
> Remove redundant 'return' statement for 'void' functions.
>
> Signed-off-by: Baolin Wang <[email protected]>

Gentle ping?

> ---
> block/blk-iocost.c | 2 +-
> block/blk-iolatency.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-iocost.c b/block/blk-iocost.c
> index ef9476f..e38c406 100644
> --- a/block/blk-iocost.c
> +++ b/block/blk-iocost.c
> @@ -3343,7 +3343,7 @@ static int __init ioc_init(void)
>
> static void __exit ioc_exit(void)
> {
> - return blkcg_policy_unregister(&blkcg_policy_iocost);
> + blkcg_policy_unregister(&blkcg_policy_iocost);
> }
>
> module_init(ioc_init);
> diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c
> index f90429c..81be009 100644
> --- a/block/blk-iolatency.c
> +++ b/block/blk-iolatency.c
> @@ -1046,7 +1046,7 @@ static int __init iolatency_init(void)
>
> static void __exit iolatency_exit(void)
> {
> - return blkcg_policy_unregister(&blkcg_policy_iolatency);
> + blkcg_policy_unregister(&blkcg_policy_iolatency);
> }
>
> module_init(iolatency_init);
> --
> 1.8.3.1

2020-10-08 15:54:24

by Jens Axboe

Subject: Re: [PATCH] block: Remove redundant 'return' statement

On 9/27/20 6:42 PM, Baolin Wang wrote:
> Remove redundant 'return' statement for 'void' functions.

Applied, thanks.

--
Jens Axboe