2020-10-09 08:04:53

by Tabot Kevin

Subject: [PATCH] Fixed coding style issues raised by checkpatch.

This patch fixes the following:
- Made sure alignment matched open parenthesis.

Signed-off-by: Tabot Kevin <[email protected]>
---
drivers/staging/greybus/audio_module.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/greybus/audio_module.c b/drivers/staging/greybus/audio_module.c
index c52c4f3..a243d60 100644
--- a/drivers/staging/greybus/audio_module.c
+++ b/drivers/staging/greybus/audio_module.c
@@ -175,8 +175,8 @@ static int gbaudio_codec_request_handler(struct gb_operation *op)
}

static int gb_audio_add_mgmt_connection(struct gbaudio_module_info *gbmodule,
- struct greybus_descriptor_cport *cport_desc,
- struct gb_bundle *bundle)
+ struct greybus_descriptor_cport *cport_desc,
+ struct gb_bundle *bundle)
{
struct gb_connection *connection;

@@ -199,8 +199,8 @@ static int gb_audio_add_mgmt_connection(struct gbaudio_module_info *gbmodule,
}

static int gb_audio_add_data_connection(struct gbaudio_module_info *gbmodule,
- struct greybus_descriptor_cport *cport_desc,
- struct gb_bundle *bundle)
+ struct greybus_descriptor_cport *cport_desc,
+ struct gb_bundle *bundle)
{
struct gb_connection *connection;
struct gbaudio_data_connection *dai;
--
2.7.4

2020-10-09 08:20:19

by Greg Kroah-Hartman

Subject: Re: [PATCH] Fixed coding style issues raised by checkpatch.

On Fri, Oct 09, 2020 at 09:00:38AM +0100, Tabot Kevin wrote:
> This patch fixes the following:
> - Made sure alignment matched open parenthesis.
>
> Signed-off-by: Tabot Kevin <[email protected]>
> ---
> drivers/staging/greybus/audio_module.c | 8 ++++----

As my bot asked you to, please use scripts/get_maintainer.pl to
determine who, and what mailing lists, to send patches to.

Also, I think this patch has been rejected many times in the past,
please check the archives first before sending it again.

thanks,

greg k-h

2020-10-10 06:49:27

by Joe Perches

Subject: Re: [PATCH] Fixed coding style issues raised by checkpatch.

On Fri, 2020-10-09 at 10:18 +0200, Greg Kroah-Hartman wrote:
> On Fri, Oct 09, 2020 at 09:00:38AM +0100, Tabot Kevin wrote:
> > This patch fixes the following:
> > - Made sure alignment matched open parenthesis.
> >
> > Signed-off-by: Tabot Kevin <[email protected]>
> > ---
> > drivers/staging/greybus/audio_module.c | 8 ++++----
>
> As my bot asked you to, please use scripts/get_maintainer.pl to
> determine who, and what mailing lists, to send patches to.

fyi Tabot, he means you to use:

$ ./scripts/get_maintainer.pl -f drivers/staging/greybus/audio_module.c
Vaibhav Agarwal <[email protected]> (maintainer:GREYBUS AUDIO PROTOCOLS DRIVERS)
Mark Greer <[email protected]> (maintainer:GREYBUS AUDIO PROTOCOLS DRIVERS)
Johan Hovold <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
Alex Elder <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
Greg Kroah-Hartman <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
[email protected] (moderated list:GREYBUS SUBSYSTEM)
[email protected] (open list:STAGING SUBSYSTEM)
[email protected] (open list)

> Also, I think this patch has been rejected many times in the past,
> please check the archives first before sending it again.

Doubtful about that as almost the entire file uses
alignment to open parenthesis.