LinuxLists.cc - -next: Kconfig asks about XFS formats when I don't have XFS enabled

2020-10-12 20:46:19

Subject: -next: Kconfig asks about XFS formats when I don't have XFS enabled

Hi!

I don't have XFS enabled, yet I'm asked if I want to support its old
format:

+config XFS_SUPPORT_V4
+ bool "Support deprecated V4 (crc=0) format"
+ default y

This needs to have dependence on XFS_FS.

+ This option will become default N in September 2025. Support for the
+ V4 format will be removed entirely in September 2030. Distributors
+ can say N here to withdraw support earlier.

This seems... "interesting", contrary to "no regressions" rule.

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachments:

(No filename) (682.00 B)
signature.asc (188.00 B)
Digital signature Download all attachments

2020-10-13 10:40:51

by Darrick J. Wong

[permalink] [raw]

Subject: Re: -next: Kconfig asks about XFS formats when I don't have XFS enabled

On Mon, Oct 12, 2020 at 12:20:39PM +0200, Pavel Machek wrote:
> Hi!
>
> I don't have XFS enabled, yet I'm asked if I want to support its old
> format:
>
> +config XFS_SUPPORT_V4
> + bool "Support deprecated V4 (crc=0) format"
> + default y
>
> This needs to have dependence on XFS_FS.
>
> + This option will become default N in September 2025. Support for the
> + V4 format will be removed entirely in September 2030. Distributors
> + can say N here to withdraw support earlier.
>
> This seems... "interesting", contrary to "no regressions" rule.

Oops, yeah, that should be gated on XFS_FS. I'll send a quick fix.

--D

> Best regards,
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html