2020-10-13 17:16:49

by Thomas Gleixner

Subject: [patch 2/4] media: omap3isp: Remove misleading comment

in_interrupt() covers hard and soft interrupt servicing and bottom half
disabled contexts, which is semantically ill defined.

The comment for __ccdc_lsc_configure() "Context: in_interrupt()" is
therefore as useful as "Context: unknown'. Remove it.

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: [email protected]

---
drivers/media/platform/omap3isp/ispccdc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

--- a/drivers/media/platform/omap3isp/ispccdc.c
+++ b/drivers/media/platform/omap3isp/ispccdc.c
@@ -299,11 +299,10 @@ static int ccdc_lsc_busy(struct isp_ccdc
ISPCCDC_LSC_BUSY;
}

-/* __ccdc_lsc_configure - Apply a new configuration to the LSC engine
+/*
+ * __ccdc_lsc_configure - Apply a new configuration to the LSC engine
* @ccdc: Pointer to ISP CCDC device
* @req: New configuration request
- *
- * context: in_interrupt()
*/
static int __ccdc_lsc_configure(struct isp_ccdc_device *ccdc,
struct ispccdc_lsc_config_req *req)

2020-10-13 19:26:32

by Laurent Pinchart

Subject: Re: [patch 2/4] media: omap3isp: Remove misleading comment

Hi Thomas,

Thank you for the patch.

On Tue, Oct 13, 2020 at 04:26:18PM +0200, Thomas Gleixner wrote:
> in_interrupt() covers hard and soft interrupt servicing and bottom half
> disabled contexts, which is semantically ill defined.
>
> The comment for __ccdc_lsc_configure() "Context: in_interrupt()" is
> therefore as useful as "Context: unknown'. Remove it.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Cc: [email protected]

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/media/platform/omap3isp/ispccdc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> --- a/drivers/media/platform/omap3isp/ispccdc.c
> +++ b/drivers/media/platform/omap3isp/ispccdc.c
> @@ -299,11 +299,10 @@ static int ccdc_lsc_busy(struct isp_ccdc
> ISPCCDC_LSC_BUSY;
> }
>
> -/* __ccdc_lsc_configure - Apply a new configuration to the LSC engine
> +/*
> + * __ccdc_lsc_configure - Apply a new configuration to the LSC engine
> * @ccdc: Pointer to ISP CCDC device
> * @req: New configuration request
> - *
> - * context: in_interrupt()
> */
> static int __ccdc_lsc_configure(struct isp_ccdc_device *ccdc,
> struct ispccdc_lsc_config_req *req)
>

--
Regards,

Laurent Pinchart