On Thu, 15 Oct 2020 16:24:15 +0200 Roger Pau Monne <[email protected]> wrote:
> Assume that reads and writes to the variable will be atomic. The worse
> that could happen is that one of the LRU intervals is not calculated
> properly if a partially written value is read, but that would only be
> a transient issue.
>
> Signed-off-by: Roger Pau Monné <[email protected]>
> ---
> Cc: Konrad Rzeszutek Wilk <[email protected]>
> Cc: Jens Axboe <[email protected]>
> Cc: Boris Ostrovsky <[email protected]>
> Cc: SeongJae Park <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: J. Roeleveld <[email protected]>
> Cc: Jürgen Groß <[email protected]>
> ---
> Documentation/ABI/testing/sysfs-driver-xen-blkback | 10 ++++++++++
> drivers/block/xen-blkback/blkback.c | 9 ++++++---
> 2 files changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkback b/Documentation/ABI/testing/sysfs-driver-xen-blkback
> index ecb7942ff146..776f25d335ca 100644
> --- a/Documentation/ABI/testing/sysfs-driver-xen-blkback
> +++ b/Documentation/ABI/testing/sysfs-driver-xen-blkback
> @@ -35,3 +35,13 @@ Description:
> controls the duration in milliseconds that blkback will not
> cache any page not backed by a grant mapping.
> The default is 10ms.
> +
> +What: /sys/module/xen_blkback/parameters/lru_internval
> +Date: October 2020
> +KernelVersion: 5.10
> +Contact: Roger Pau Monné <[email protected]>
> +Description:
> + The LRU mechanism to clean the lists of persistent grants needs
> + to be executed periodically. This parameter controls the time
> + interval between consecutive executions of the purge mechanism
> + is set in ms.
I think noticing the default value (100ms) here would be better.
Thanks,
SeongJae Park