2020-10-15 13:04:13

by Miaohe Lin

Subject: [PATCH] zsmalloc: Rework the list_add code in insert_zspage()

Rework the list_add code to make it more readable and simplicity.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/zsmalloc.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 918c7b019b3d..b03bee2e1b5f 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -730,13 +730,10 @@ static void insert_zspage(struct size_class *class,
* We want to see more ZS_FULL pages and less almost empty/full.
* Put pages with higher ->inuse first.
*/
- if (head) {
- if (get_zspage_inuse(zspage) < get_zspage_inuse(head)) {
- list_add(&zspage->list, &head->list);
- return;
- }
- }
- list_add(&zspage->list, &class->fullness_list[fullness]);
+ if (head && get_zspage_inuse(zspage) < get_zspage_inuse(head))
+ list_add(&zspage->list, &head->list);
+ else
+ list_add(&zspage->list, &class->fullness_list[fullness]);
}

/*
--
2.19.1

2020-10-15 22:08:44

by Minchan Kim

Subject: Re: [PATCH] zsmalloc: Rework the list_add code in insert_zspage()

On Thu, Oct 15, 2020 at 09:01:07AM -0400, Miaohe Lin wrote:
> Rework the list_add code to make it more readable and simplicity.
>
> Signed-off-by: Miaohe Lin <[email protected]>
Acked-by: Minchan Kim <[email protected]>

2020-10-16 02:45:13

by Sergey Senozhatsky

Subject: Re: [PATCH] zsmalloc: Rework the list_add code in insert_zspage()

On (20/10/15 11:51), Minchan Kim wrote:
> On Thu, Oct 15, 2020 at 09:01:07AM -0400, Miaohe Lin wrote:
> > Rework the list_add code to make it more readable and simplicity.
> >
> > Signed-off-by: Miaohe Lin <[email protected]>
> Acked-by: Minchan Kim <[email protected]>

Reviewed-by: Sergey Senozhatsky <[email protected]>

-ss