2020-10-16 14:55:28

by Dan Murphy

Subject: [PATCH v2] dt-bindings: leds: Update devicetree documents for ID_RGB

Update the leds/common.yaml to indicate that the max color ID is 9.
Reflect the same change in the leds-class-multicolor.yaml

Reported-by: Zhen Lei <[email protected]>
Signed-off-by: Dan Murphy <[email protected]>
---
Documentation/devicetree/bindings/leds/common.yaml | 2 +-
.../devicetree/bindings/leds/leds-class-multicolor.yaml | 9 +++++----
2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index a2a541bca73c..0c9f912dfee6 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -43,7 +43,7 @@ properties:
LED_COLOR_ID available, add a new one.
$ref: /schemas/types.yaml#definitions/uint32
minimum: 0
- maximum: 8
+ maximum: 9

function-enumerator:
description:
diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
index b55e1f1308a4..5e2c850ec9c5 100644
--- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
@@ -16,7 +16,7 @@ description: |
modules. This is achieved by adding multi-led nodes layer to the
monochrome LED bindings.
The nodes and properties defined in this document are unique to the multicolor
- LED class. Common LED nodes and properties are inherited from the common.txt
+ LED class. Common LED nodes and properties are inherited from the common.yaml
within this documentation directory.

patternProperties:
@@ -25,10 +25,11 @@ patternProperties:
description: Represents the LEDs that are to be grouped.
properties:
color:
- const: 8 # LED_COLOR_ID_MULTI
description: |
- For multicolor LED support this property should be defined as
- LED_COLOR_ID_MULTI which can be found in include/linux/leds/common.h.
+ For multicolor LED support this property should be defined as either
+ LED_COLOR_ID_RGB or LED_COLOR_ID_MULTI which can be found in
+ include/linux/leds/common.h.
+ enum: [ 8, 9 ]

$ref: "common.yaml#"

--
2.28.0.585.ge1cfff676549

2020-10-23 18:58:15

by Rob Herring

Subject: Re: [PATCH v2] dt-bindings: leds: Update devicetree documents for ID_RGB

On Fri, 16 Oct 2020 06:57:03 -0500, Dan Murphy wrote:
> Update the leds/common.yaml to indicate that the max color ID is 9.
> Reflect the same change in the leds-class-multicolor.yaml
>
> Reported-by: Zhen Lei <[email protected]>
> Signed-off-by: Dan Murphy <[email protected]>
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 2 +-
> .../devicetree/bindings/leds/leds-class-multicolor.yaml | 9 +++++----
> 2 files changed, 6 insertions(+), 5 deletions(-)
>

Applied, thanks!