2020-10-18 03:50:51

by Vaishnav M A

Subject: [PATCH v2] iio: light: vcnl4035 add i2c_device_id

add i2c_device_id for the vcnl4035 driver so that
the device can be instantiated using i2c_new_client_device
or from userspace, useful in cases where device tree based
description is not possible now(Eg. a device on a gbphy i2c
adapter created by greybus)

Signed-off-by: Vaishnav M A <[email protected]>
---
v2:
- fix commit message
drivers/iio/light/vcnl4035.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
index 765c44adac57..73a28e30dddc 100644
--- a/drivers/iio/light/vcnl4035.c
+++ b/drivers/iio/light/vcnl4035.c
@@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
vcnl4035_runtime_resume, NULL)
};

+static const struct i2c_device_id vcnl4035_id[] = {
+ { "vcnl4035", 0},
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
+
static const struct of_device_id vcnl4035_of_match[] = {
{ .compatible = "vishay,vcnl4035", },
{ }
@@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
},
.probe = vcnl4035_probe,
.remove = vcnl4035_remove,
+ .id_table = vcnl4035_id,
};

module_i2c_driver(vcnl4035_driver);
--
2.25.1

2020-10-18 12:57:57

by Jonathan Cameron

Subject: Re: [PATCH v2] iio: light: vcnl4035 add i2c_device_id

On Sun, 18 Oct 2020 09:06:02 +0530
Vaishnav M A <[email protected]> wrote:

> add i2c_device_id for the vcnl4035 driver so that
> the device can be instantiated using i2c_new_client_device
> or from userspace, useful in cases where device tree based
> description is not possible now(Eg. a device on a gbphy i2c
> adapter created by greybus)
>
> Signed-off-by: Vaishnav M A <[email protected]>
Rewrite the description and this should be fine.

Thanks,

Jonathan

> ---
> v2:
> - fix commit message
> drivers/iio/light/vcnl4035.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
> index 765c44adac57..73a28e30dddc 100644
> --- a/drivers/iio/light/vcnl4035.c
> +++ b/drivers/iio/light/vcnl4035.c
> @@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
> vcnl4035_runtime_resume, NULL)
> };
>
> +static const struct i2c_device_id vcnl4035_id[] = {
> + { "vcnl4035", 0},
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
> +
> static const struct of_device_id vcnl4035_of_match[] = {
> { .compatible = "vishay,vcnl4035", },
> { }
> @@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
> },
> .probe = vcnl4035_probe,
> .remove = vcnl4035_remove,
> + .id_table = vcnl4035_id,
> };
>
> module_i2c_driver(vcnl4035_driver);

2020-10-18 15:49:32

by Vaishnav M A

Subject: Re: [PATCH v2] iio: light: vcnl4035 add i2c_device_id

On Sun, Oct 18, 2020 at 5:06 PM Jonathan Cameron <[email protected]> wrote:
>
> On Sun, 18 Oct 2020 09:06:02 +0530
> Vaishnav M A <[email protected]> wrote:
>
> > add i2c_device_id for the vcnl4035 driver so that
> > the device can be instantiated using i2c_new_client_device
> > or from userspace, useful in cases where device tree based
> > description is not possible now(Eg. a device on a gbphy i2c
> > adapter created by greybus)
> >
> > Signed-off-by: Vaishnav M A <[email protected]>
> Rewrite the description and this should be fine.
>
> Thanks,
>
> Jonathan
>
Thank you Jonathan for the Review, I have submitted v3 patch
with the modified description: https://lore.kernel.org/patchwork/patch/1322195/

Thanks,
Vaishnav
> > ---
> > v2:
> > - fix commit message
> > drivers/iio/light/vcnl4035.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
> > index 765c44adac57..73a28e30dddc 100644
> > --- a/drivers/iio/light/vcnl4035.c
> > +++ b/drivers/iio/light/vcnl4035.c
> > @@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
> > vcnl4035_runtime_resume, NULL)
> > };
> >
> > +static const struct i2c_device_id vcnl4035_id[] = {
> > + { "vcnl4035", 0},
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
> > +
> > static const struct of_device_id vcnl4035_of_match[] = {
> > { .compatible = "vishay,vcnl4035", },
> > { }
> > @@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
> > },
> > .probe = vcnl4035_probe,
> > .remove = vcnl4035_remove,
> > + .id_table = vcnl4035_id,
> > };
> >
> > module_i2c_driver(vcnl4035_driver);
>