2020-10-19 04:28:42

by Fabien Parent

Subject: [PATCH] dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value

As the binding documentation says, #mbox-cells must have a value of 2,
but the example use a value 3. The MT8173 device tree correctly use
mbox-cells = <2>. This commit fixes the example.

Signed-off-by: Fabien Parent <[email protected]>
---
Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
index cf48cd806e00..7771ecaac586 100644
--- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
+++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
@@ -47,7 +47,7 @@ Example:
interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_LOW>;
clocks = <&infracfg CLK_INFRA_GCE>;
clock-names = "gce";
- #mbox-cells = <3>;
+ #mbox-cells = <2>;
};

Example for a client device:
--
2.28.0

2020-10-19 11:36:03

by Matthias Brugger

Subject: Re: [PATCH] dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value

On 18/10/2020 21:30, Fabien Parent wrote:
> As the binding documentation says, #mbox-cells must have a value of 2,
> but the example use a value 3. The MT8173 device tree correctly use
> mbox-cells = <2>. This commit fixes the example.
>
> Signed-off-by: Fabien Parent <[email protected]>
> ---

Fixes: 19d8e335d58a ("dt-binding: gce: remove atomic_exec in mboxes property")

With that:
Reviewed-by: Matthias Brugger <[email protected]>

> Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> index cf48cd806e00..7771ecaac586 100644
> --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> @@ -47,7 +47,7 @@ Example:
> interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_LOW>;
> clocks = <&infracfg CLK_INFRA_GCE>;
> clock-names = "gce";
> - #mbox-cells = <3>;
> + #mbox-cells = <2>;
> };
>
> Example for a client device:
>

2020-10-23 18:56:18

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value

On Sun, 18 Oct 2020 21:30:16 +0200, Fabien Parent wrote:
> As the binding documentation says, #mbox-cells must have a value of 2,
> but the example use a value 3. The MT8173 device tree correctly use
> mbox-cells = <2>. This commit fixes the example.
>
> Signed-off-by: Fabien Parent <[email protected]>
> ---
> Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied, thanks!