2020-10-19 08:36:04

by Vaishnav M A

Subject: [PATCH v4] iio: proximity: vl53l0x-i2c add i2c_device_id

Add i2c_device_id table for the vl53l0x-i2c driver,
helps in device instantiation using i2c_new_client_device()
or from userspace in cases where device-tree based description
is not possible now, like device(s) on a gbphy i2c adapter
created by greybus.

Signed-off-by: Vaishnav M A <[email protected]>

---
v4:
-update commit message, add punctuation
v3:
-modify commit message for readability
as suggested by Jonathan Cameron
v2:
-fix commit message
drivers/iio/proximity/vl53l0x-i2c.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/iio/proximity/vl53l0x-i2c.c b/drivers/iio/proximity/vl53l0x-i2c.c
index 5fbda9475ba9..7c29d4cae24a 100644
--- a/drivers/iio/proximity/vl53l0x-i2c.c
+++ b/drivers/iio/proximity/vl53l0x-i2c.c
@@ -143,6 +143,12 @@ static int vl53l0x_probe(struct i2c_client *client)
return devm_iio_device_register(&client->dev, indio_dev);
}

+static const struct i2c_device_id vl53l0x_id[] = {
+ { "vl53l0x", 0},
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, vl53l0x_id);
+
static const struct of_device_id st_vl53l0x_dt_match[] = {
{ .compatible = "st,vl53l0x", },
{ }
@@ -155,6 +161,7 @@ static struct i2c_driver vl53l0x_driver = {
.of_match_table = st_vl53l0x_dt_match,
},
.probe_new = vl53l0x_probe,
+ .id_table = vl53l0x_id,
};
module_i2c_driver(vl53l0x_driver);

--
2.25.1

2020-11-01 15:20:08

by Jonathan Cameron

Subject: Re: [PATCH v4] iio: proximity: vl53l0x-i2c add i2c_device_id

On Mon, 19 Oct 2020 01:21:02 +0530
Vaishnav M A <[email protected]> wrote:

> Add i2c_device_id table for the vl53l0x-i2c driver,
> helps in device instantiation using i2c_new_client_device()
> or from userspace in cases where device-tree based description
> is not possible now, like device(s) on a gbphy i2c adapter
> created by greybus.
>
> Signed-off-by: Vaishnav M A <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see if they can find any issues.

Thanks,

Jonathan

>
> ---
> v4:
> -update commit message, add punctuation
> v3:
> -modify commit message for readability
> as suggested by Jonathan Cameron
> v2:
> -fix commit message
> drivers/iio/proximity/vl53l0x-i2c.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/proximity/vl53l0x-i2c.c b/drivers/iio/proximity/vl53l0x-i2c.c
> index 5fbda9475ba9..7c29d4cae24a 100644
> --- a/drivers/iio/proximity/vl53l0x-i2c.c
> +++ b/drivers/iio/proximity/vl53l0x-i2c.c
> @@ -143,6 +143,12 @@ static int vl53l0x_probe(struct i2c_client *client)
> return devm_iio_device_register(&client->dev, indio_dev);
> }
>
> +static const struct i2c_device_id vl53l0x_id[] = {
> + { "vl53l0x", 0},
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, vl53l0x_id);
> +
> static const struct of_device_id st_vl53l0x_dt_match[] = {
> { .compatible = "st,vl53l0x", },
> { }
> @@ -155,6 +161,7 @@ static struct i2c_driver vl53l0x_driver = {
> .of_match_table = st_vl53l0x_dt_match,
> },
> .probe_new = vl53l0x_probe,
> + .id_table = vl53l0x_id,
> };
> module_i2c_driver(vl53l0x_driver);
>