2020-10-20 07:18:56

by Tom Rix

Subject: [PATCH] power: remove unneeded break

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a goto

Signed-off-by: Tom Rix <[email protected]>
---
drivers/power/supply/wm831x_power.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/power/supply/wm831x_power.c b/drivers/power/supply/wm831x_power.c
index 18b33f14dfee..4cd2dd870039 100644
--- a/drivers/power/supply/wm831x_power.c
+++ b/drivers/power/supply/wm831x_power.c
@@ -668,7 +668,6 @@ static int wm831x_power_probe(struct platform_device *pdev)
fallthrough;
case -EPROBE_DEFER:
goto err_bat_irq;
- break;
}

return ret;
--
2.18.1

2020-10-26 10:41:39

by Charles Keepax

Subject: Re: [PATCH] power: remove unneeded break

On Mon, Oct 19, 2020 at 11:59:37AM -0700, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> A break is not needed if it is preceded by a goto
>
> Signed-off-by: Tom Rix <[email protected]>
> ---

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles