2020-10-19 19:35:49

by Tom Rix

[permalink] [raw]
Subject: [PATCH] ipack: iopctal: remove unneeded break

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

Signed-off-by: Tom Rix <[email protected]>
---
drivers/ipack/devices/ipoctal.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c
index d480a514c983..3940714e4397 100644
--- a/drivers/ipack/devices/ipoctal.c
+++ b/drivers/ipack/devices/ipoctal.c
@@ -544,7 +544,6 @@ static void ipoctal_set_termios(struct tty_struct *tty,
break;
default:
return;
- break;
}

baud = tty_get_baud_rate(tty);
--
2.18.1


Subject: Re: [Industrypack-devel] [PATCH] ipack: iopctal: remove unneeded break

Hi Tom,

Thanks for the patch!

Patch is,

Acked-by: Samuel Iglesias Gonsalvez <[email protected]>

Greg, Would you mind picking this patch through your char-misc
tree?

Thanks!

Sam

On Mon, 2020-10-19 at 12:32 -0700, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/ipack/devices/ipoctal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ipack/devices/ipoctal.c
> b/drivers/ipack/devices/ipoctal.c
> index d480a514c983..3940714e4397 100644
> --- a/drivers/ipack/devices/ipoctal.c
> +++ b/drivers/ipack/devices/ipoctal.c
> @@ -544,7 +544,6 @@ static void ipoctal_set_termios(struct tty_struct
> *tty,
> break;
> default:
> return;
> - break;
> }
>
> baud = tty_get_baud_rate(tty);

Attachments:
signature.asc (849.00 B)
This is a digitally signed message part