2020-10-20 11:23:45

by Pekka Paalanen

[permalink] [raw]
Subject: Re: [PATCH] x86/mm/kmmio: correctly handle kzalloc return

On Tue, 20 Oct 2020 14:13:44 +0530
Mugilraj Dhavachelvan <[email protected]> wrote:

> Replacing return value -1 to error code
>
> Signed-off-by: Mugilraj Dhavachelvan <[email protected]>
> ---
> arch/x86/mm/kmmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c
> index be020a7bc414..15430520c232 100644
> --- a/arch/x86/mm/kmmio.c
> +++ b/arch/x86/mm/kmmio.c
> @@ -386,7 +386,7 @@ static int add_kmmio_fault_page(unsigned long addr)
>
> f = kzalloc(sizeof(*f), GFP_ATOMIC);
> if (!f)
> - return -1;
> + return -ENOMEN;
>
> f->count = 1;
> f->addr = addr;

Hi,

did you even build-test this?

Why did you write this patch? What does it achieve?


Thanks,
pq


Attachments:
(No filename) (849.00 B)
OpenPGP digital signature