Hi,
We're looking to improve our crash data capture for the BMC on some IBM
platforms. This small series enables ramoops for Rainier and Tacoma.
v2 fixes an address overlap bug for Tacoma in v1, which was caused by a node vs
reg mismatch of one of the other reserved memory regions. v2 contains a several
cosmetic cleanups for both the Tacoma and Rainier reserved memory regions
before enabling ramoops in the final two patches. The geometry of the rings has
changed from v1; the slot sizes have been doubled, reducing the captured crash
count from 32 to 16 (32 seemed like overkill and we could trade that for more
space in each slot).
v1 can be found here:
https://lore.kernel.org/linux-arm-kernel/[email protected]/
Please review.
Andrew
Andrew Jeffery (6):
ARM: dts: tacoma: Fix node vs reg mismatch for flash memory
ARM: dts: tacoma: Zero-pad flash memory region length
ARM: dts: rainier,tacoma: Fix size comment whitespace
ARM: dts: rainier,tacoma: Comment reserved memory regions
ARM: dts: rainier: Add reserved memory for ramoops
ARM: dts: tacoma: Add reserved memory for ramoops
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 15 ++++++++++++++-
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 19 ++++++++++++++++---
2 files changed, 30 insertions(+), 4 deletions(-)
--
2.25.1
Makes it easier to understand the magnitude at a glance.
Signed-off-by: Andrew Jeffery <[email protected]>
---
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
index e86c22ce6d12..67ab57ad4d8d 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
@@ -28,7 +28,7 @@ reserved-memory {
flash_memory: region@b8000000 {
no-map;
- reg = <0xb8000000 0x4000000>; /* 64M */
+ reg = <0xb8000000 0x04000000>; /* 64M */
};
vga_memory: region@bf000000 {
--
2.25.1
Reserve a 1.5MiB region of memory to record kmsg dumps, console and
userspace message state into 16kiB ring-buffer slots. The sizing allows
for up to 16 dumps to be captured and read out.
Set max-reason to KMSG_DUMP_EMERG to capture bad-path reboots.
Signed-off-by: Andrew Jeffery <[email protected]>
---
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index 802027a3c43c..8431cf1b32e6 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -55,6 +55,15 @@ flash_memory: region@B8000000 {
/* 48MB region from the end of flash to start of vga memory */
+ ramoops@bc000000 {
+ compatible = "ramoops";
+ reg = <0xbc000000 0x180000>; /* 16 * (3 * 0x8000) */
+ record-size = <0x8000>;
+ console-size = <0x8000>;
+ pmsg-size = <0x8000>;
+ max-reason = <3>; /* KMSG_DUMP_EMERG */
+ };
+
/* VGA region is dictated by hardware strapping */
vga_memory: region@bf000000 {
no-map;
--
2.25.1
On Thu, 22 Oct 2020 at 01:48, Andrew Jeffery <[email protected]> wrote:
>
> Reserve a 1.5MiB region of memory to record kmsg dumps, console and
> userspace message state into 16kiB ring-buffer slots. The sizing allows
> for up to 16 dumps to be captured and read out.
>
> Set max-reason to KMSG_DUMP_EMERG to capture bad-path reboots.
>
> Signed-off-by: Andrew Jeffery <[email protected]>
Reviewed-by: Joel Stanley <[email protected]>
> ---
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 802027a3c43c..8431cf1b32e6 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -55,6 +55,15 @@ flash_memory: region@B8000000 {
>
> /* 48MB region from the end of flash to start of vga memory */
>
> + ramoops@bc000000 {
> + compatible = "ramoops";
> + reg = <0xbc000000 0x180000>; /* 16 * (3 * 0x8000) */
> + record-size = <0x8000>;
> + console-size = <0x8000>;
> + pmsg-size = <0x8000>;
> + max-reason = <3>; /* KMSG_DUMP_EMERG */
> + };
> +
> /* VGA region is dictated by hardware strapping */
> vga_memory: region@bf000000 {
> no-map;
> --
> 2.25.1
>