2020-10-23 09:23:45

by Xu Wang

Subject: [PATCH] net: microchip: Remove unneeded variable ret

Remove unneeded variable ret used to store return value.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/net/ethernet/microchip/lan743x_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index a1938842f828..8ea0b4eec19c 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -834,14 +834,13 @@ static int lan743x_mac_init(struct lan743x_adapter *adapter)

static int lan743x_mac_open(struct lan743x_adapter *adapter)
{
- int ret = 0;
u32 temp;

temp = lan743x_csr_read(adapter, MAC_RX);
lan743x_csr_write(adapter, MAC_RX, temp | MAC_RX_RXEN_);
temp = lan743x_csr_read(adapter, MAC_TX);
lan743x_csr_write(adapter, MAC_TX, temp | MAC_TX_TXEN_);
- return ret;
+ return 0;
}

static void lan743x_mac_close(struct lan743x_adapter *adapter)
--
2.17.1

2020-10-28 21:40:59

by Jakub Kicinski

Subject: Re: [PATCH] net: microchip: Remove unneeded variable ret

On Fri, 23 Oct 2020 09:21:07 +0000 Xu Wang wrote:
> Remove unneeded variable ret used to store return value.
>
> Signed-off-by: Xu Wang <[email protected]>

Applied.