2020-10-23 23:47:28

by Jernej Skrabec

[permalink] [raw]

Subject: [PATCH] arm64: dts: allwinner: h6: Pine H64: Fix ethernet node

---

Ethernet PHY provides RX and TX delay on both models, A and B. Although
schematic for model A suggests only TX delay, network never worked with
such configuration.

Fix ethernet node to reflect PHY delays.

Fixes: 729e1ffcf47e ("arm64: allwinner: h6: add support for the Ethernet on Pine H64")
Signed-off-by: Jernej Skrabec <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
index af85b2074867..961732c52aa0 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
@@ -100,7 +100,7 @@ &ehci3 {
&emac {
pinctrl-names = "default";
pinctrl-0 = <&ext_rgmii_pins>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-handle = <&ext_rgmii_phy>;
phy-supply = <&reg_gmac_3v3>;
allwinner,rx-delay-ps = <200>;
--
2.29.0

2020-10-26 11:54:48

by Maxime Ripard

[permalink] [raw]

Subject: Re: [PATCH] arm64: dts: allwinner: h6: Pine H64: Fix ethernet node

---

On Fri, Oct 23, 2020 at 09:49:02PM +0200, Jernej Skrabec wrote:
> Ethernet PHY provides RX and TX delay on both models, A and B. Although
> schematic for model A suggests only TX delay, network never worked with
> such configuration.
>
> Fix ethernet node to reflect PHY delays.
>
> Fixes: 729e1ffcf47e ("arm64: allwinner: h6: add support for the Ethernet on Pine H64")
> Signed-off-by: Jernej Skrabec <[email protected]>

Corentin sent the same patch last week. It's part of the fixes branch already.

maxime

---

Attachments:

(No filename) (531.00 B)
signature.asc (235.00 B)
Download all attachments