2020-10-20 07:26:34

by Tom Rix

Subject: [PATCH] edac: amd64_edac: remove unneeded break

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

Signed-off-by: Tom Rix <[email protected]>
---
drivers/edac/amd64_edac.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index fcc08bbf6945..386a3a4cf279 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -2461,14 +2461,11 @@ static int map_err_sym_to_channel(int err_sym, int sym_size)
case 0x20:
case 0x21:
return 0;
- break;
case 0x22:
case 0x23:
return 1;
- break;
default:
return err_sym >> 4;
- break;
}
/* x8 symbols */
else
@@ -2478,17 +2475,12 @@ static int map_err_sym_to_channel(int err_sym, int sym_size)
WARN(1, KERN_ERR "Invalid error symbol: 0x%x\n",
err_sym);
return -1;
- break;
-
case 0x11:
return 0;
- break;
case 0x12:
return 1;
- break;
default:
return err_sym >> 3;
- break;
}
return -1;
}
--
2.18.1

2020-10-20 07:58:11

by Robert Richter

Subject: Re: [PATCH] edac: amd64_edac: remove unneeded break

On 19.10.20 12:35:24, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Robert Richter <[email protected]>

2020-10-26 12:54:05

by Borislav Petkov

Subject: Re: [PATCH] edac: amd64_edac: remove unneeded break

On Mon, Oct 19, 2020 at 12:35:24PM -0700, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/edac/amd64_edac.c | 8 --------
> 1 file changed, 8 deletions(-)

Applied, thanks.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette