2020-10-26 13:19:47

by Vincenzo Frascino

Subject: [PATCH 3/6] kselftest/arm64: Fix check_child_memory test

The check_child_memory test reports the error below because the test
plan is not declared correctly:

# Planned tests != run tests (0 != 12)

Fix the test adding the correct test plan declaration.

Fixes: dfe537cf4718 ("kselftest/arm64: Check forked child mte memory accessibility")
Cc: Shuah Khan <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: Gabor Kertesz <[email protected]>
Cc: Amit Daniel Kachhap <[email protected]>
Signed-off-by: Vincenzo Frascino <[email protected]>
---
tools/testing/selftests/arm64/mte/check_child_memory.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/tools/testing/selftests/arm64/mte/check_child_memory.c b/tools/testing/selftests/arm64/mte/check_child_memory.c
index 97bebdecd29e..43bd94f853ba 100644
--- a/tools/testing/selftests/arm64/mte/check_child_memory.c
+++ b/tools/testing/selftests/arm64/mte/check_child_memory.c
@@ -163,6 +163,9 @@ int main(int argc, char *argv[])
mte_register_signal(SIGSEGV, mte_default_handler);
mte_register_signal(SIGBUS, mte_default_handler);

+ /* Set test plan */
+ ksft_set_plan(12);
+
evaluate_test(check_child_memory_mapping(USE_MMAP, MTE_SYNC_ERR, MAP_PRIVATE),
"Check child anonymous memory with private mapping, precise mode and mmap memory\n");
evaluate_test(check_child_memory_mapping(USE_MMAP, MTE_SYNC_ERR, MAP_SHARED),
--
2.28.0

2020-10-27 14:34:38

by Amit Kachhap

Subject: Re: [PATCH 3/6] kselftest/arm64: Fix check_child_memory test

On 10/26/20 5:42 PM, Vincenzo Frascino wrote:
> The check_child_memory test reports the error below because the test
> plan is not declared correctly:
>
> # Planned tests != run tests (0 != 12)
>
> Fix the test adding the correct test plan declaration.

This change is required and got missed earlier.
Acked by: Amit Daniel Kachhap <[email protected]>

>
> Fixes: dfe537cf4718 ("kselftest/arm64: Check forked child mte memory accessibility")
> Cc: Shuah Khan <[email protected]>
> Cc: Catalin Marinas <[email protected]>
> Cc: Will Deacon <[email protected]>
> Cc: Gabor Kertesz <[email protected]>
> Cc: Amit Daniel Kachhap <[email protected]>
> Signed-off-by: Vincenzo Frascino <[email protected]>
> ---
> tools/testing/selftests/arm64/mte/check_child_memory.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/arm64/mte/check_child_memory.c b/tools/testing/selftests/arm64/mte/check_child_memory.c
> index 97bebdecd29e..43bd94f853ba 100644
> --- a/tools/testing/selftests/arm64/mte/check_child_memory.c
> +++ b/tools/testing/selftests/arm64/mte/check_child_memory.c
> @@ -163,6 +163,9 @@ int main(int argc, char *argv[])
> mte_register_signal(SIGSEGV, mte_default_handler);
> mte_register_signal(SIGBUS, mte_default_handler);
>
> + /* Set test plan */
> + ksft_set_plan(12);
> +
> evaluate_test(check_child_memory_mapping(USE_MMAP, MTE_SYNC_ERR, MAP_PRIVATE),
> "Check child anonymous memory with private mapping, precise mode and mmap memory\n");
> evaluate_test(check_child_memory_mapping(USE_MMAP, MTE_SYNC_ERR, MAP_SHARED),
>