2020-10-27 14:19:58

by Billy Tsai

Subject: [PATCH] pinctrl: aspeed: Fix GPI only function problem.

Some gpio pin at aspeed soc is input only and the prefix name of these
pin is "GPI" only. This patch fine-tune the condition of GPIO check from
"GPIO" to "GPI".

Signed-off-by: Billy Tsai <[email protected]>
---
drivers/pinctrl/aspeed/pinctrl-aspeed.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c
index 53f3f8aec695..a2f5ede3f897 100644
--- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c
+++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c
@@ -292,7 +292,7 @@ static bool aspeed_expr_is_gpio(const struct aspeed_sig_expr *expr)
*
* expr->signal might look like "GPIOT3" in the GPIO case.
*/
- return strncmp(expr->signal, "GPIO", 4) == 0;
+ return strncmp(expr->signal, "GPI", 3) == 0;
}

static bool aspeed_gpio_in_exprs(const struct aspeed_sig_expr **exprs)
--
2.17.1

2020-10-30 04:33:03

by Andrew Jeffery

Subject: Re: [PATCH] pinctrl: aspeed: Fix GPI only function problem.

Hi Billy,

On Tue, 27 Oct 2020, at 19:14, Billy Tsai wrote:
> Some gpio pin at aspeed soc is input only and the prefix name of these
> pin is "GPI" only. This patch fine-tune the condition of GPIO check from
> "GPIO" to "GPI".
>
> Signed-off-by: Billy Tsai <[email protected]>

I'd like it if we were a bit more specific in the commit message, and even
better if we update the comment in the code. A quick look at the code suggests
this issue affects GPIO banks D and E in the AST2400 and AST2500, and banks T
and U in the AST2600.

Functionally I think the patch is fine.

Cheers,

Andrew

> ---
> drivers/pinctrl/aspeed/pinctrl-aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c
> b/drivers/pinctrl/aspeed/pinctrl-aspeed.c
> index 53f3f8aec695..a2f5ede3f897 100644
> --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c
> +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c
> @@ -292,7 +292,7 @@ static bool aspeed_expr_is_gpio(const struct
> aspeed_sig_expr *expr)
> *
> * expr->signal might look like "GPIOT3" in the GPIO case.
> */
> - return strncmp(expr->signal, "GPIO", 4) == 0;
> + return strncmp(expr->signal, "GPI", 3) == 0;
> }
>
> static bool aspeed_gpio_in_exprs(const struct aspeed_sig_expr **exprs)
> --
> 2.17.1
>
>

2020-10-30 04:49:21

by Joel Stanley

Subject: Re: [PATCH] pinctrl: aspeed: Fix GPI only function problem.

On Fri, 30 Oct 2020 at 04:28, Andrew Jeffery <[email protected]> wrote:
>
> Hi Billy,
>
> On Tue, 27 Oct 2020, at 19:14, Billy Tsai wrote:
> > Some gpio pin at aspeed soc is input only and the prefix name of these
> > pin is "GPI" only. This patch fine-tune the condition of GPIO check from
> > "GPIO" to "GPI".
> >
> > Signed-off-by: Billy Tsai <[email protected]>
>
> I'd like it if we were a bit more specific in the commit message, and even
> better if we update the comment in the code. A quick look at the code suggests
> this issue affects GPIO banks D and E in the AST2400 and AST2500, and banks T
> and U in the AST2600.
>
> Functionally I think the patch is fine.

Also add this line:

Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs")

Cheers,

Joel

>
> Cheers,
>
> Andrew
>
> > ---
> > drivers/pinctrl/aspeed/pinctrl-aspeed.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c
> > b/drivers/pinctrl/aspeed/pinctrl-aspeed.c
> > index 53f3f8aec695..a2f5ede3f897 100644
> > --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c
> > +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c
> > @@ -292,7 +292,7 @@ static bool aspeed_expr_is_gpio(const struct
> > aspeed_sig_expr *expr)
> > *
> > * expr->signal might look like "GPIOT3" in the GPIO case.
> > */
> > - return strncmp(expr->signal, "GPIO", 4) == 0;
> > + return strncmp(expr->signal, "GPI", 3) == 0;
> > }
> >
> > static bool aspeed_gpio_in_exprs(const struct aspeed_sig_expr **exprs)
> > --
> > 2.17.1
> >
> >