2020-10-20 15:03:27

by Tom Rix

Subject: [PATCH] char: ipmi: remove unneeded break

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

Signed-off-by: Tom Rix <[email protected]>
---
drivers/char/ipmi/ipmi_devintf.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
index f7b1c004a12b..3dd1d5abb298 100644
--- a/drivers/char/ipmi/ipmi_devintf.c
+++ b/drivers/char/ipmi/ipmi_devintf.c
@@ -490,7 +490,6 @@ static long ipmi_ioctl(struct file *file,
}

return ipmi_set_my_address(priv->user, val.channel, val.value);
- break;
}

case IPMICTL_GET_MY_CHANNEL_ADDRESS_CMD:
--
2.18.1

2020-10-28 21:36:52

by Corey Minyard

Subject: Re: [PATCH] char: ipmi: remove unneeded break

On Mon, Oct 19, 2020 at 12:48:05PM -0700, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> A break is not needed if it is preceded by a return

Ok, it's in my next tree.

Thanks,

-corey

>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/char/ipmi/ipmi_devintf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
> index f7b1c004a12b..3dd1d5abb298 100644
> --- a/drivers/char/ipmi/ipmi_devintf.c
> +++ b/drivers/char/ipmi/ipmi_devintf.c
> @@ -490,7 +490,6 @@ static long ipmi_ioctl(struct file *file,
> }
>
> return ipmi_set_my_address(priv->user, val.channel, val.value);
> - break;
> }
>
> case IPMICTL_GET_MY_CHANNEL_ADDRESS_CMD:
> --
> 2.18.1
>