Adding display timings directly on device tree files make it difficult
to maintain as a same copy of timings may exist on different files or
panel-simple driver.
We have a panel-simple driver for this particular usage so supporting
on this driver will help to use the same timings on any device tree
files if the board mounted on a similar vendor display.
Engicam C.TOUCH OF 10.1" LCD board uses Ampire 10.1" TFT LCD and
it has supported by panel-simple already, so simply use that binding.
Signed-off-by: Jagan Teki <[email protected]>
---
Note:
Panel patch in ML already,
https://lkml.org/lkml/2020/8/28/685
arch/arm/boot/dts/imx6q-icore-ofcap10.dts | 28 +++++++++++++----------
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-icore-ofcap10.dts b/arch/arm/boot/dts/imx6q-icore-ofcap10.dts
index 81cc346dd149..02aca1e28ce3 100644
--- a/arch/arm/boot/dts/imx6q-icore-ofcap10.dts
+++ b/arch/arm/boot/dts/imx6q-icore-ofcap10.dts
@@ -12,6 +12,17 @@
/ {
model = "Engicam i.CoreM6 Quad/Dual OpenFrame Capacitive touch 10.1 Kit";
compatible = "engicam,imx6-icore", "fsl,imx6q";
+
+ panel {
+ compatible = "ampire,am-1280800n3tzqw-t00h";
+ backlight = <&backlight_lvds>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&lvds0_out>;
+ };
+ };
+ };
};
&ldb {
@@ -22,18 +33,11 @@ lvds-channel@0 {
fsl,data-width = <24>;
status = "okay";
- display-timings {
- native-mode = <&timing0>;
- timing0: timing0 {
- clock-frequency = <60000000>;
- hactive = <1280>;
- vactive = <800>;
- hback-porch = <40>;
- hfront-porch = <40>;
- vback-porch = <10>;
- vfront-porch = <3>;
- hsync-len = <80>;
- vsync-len = <10>;
+ port@4 {
+ reg = <4>;
+
+ lvds0_out: endpoint {
+ remote-endpoint = <&panel_in>;
};
};
};
--
2.25.1
Hi Shawn,
On Fri, Aug 28, 2020 at 9:33 PM Jagan Teki <[email protected]> wrote:
>
> Adding display timings directly on device tree files make it difficult
> to maintain as a same copy of timings may exist on different files or
> panel-simple driver.
>
> We have a panel-simple driver for this particular usage so supporting
> on this driver will help to use the same timings on any device tree
> files if the board mounted on a similar vendor display.
>
> Engicam C.TOUCH OF 10.1" LCD board uses Ampire 10.1" TFT LCD and
> it has supported by panel-simple already, so simply use that binding.
>
> Signed-off-by: Jagan Teki <[email protected]>
> ---
> Note:
> Panel patch in ML already,
> https://lkml.org/lkml/2020/8/28/685
Panel is part of the Mainline tree now, hope this can apply?
Jagan.
On Fri, Aug 28, 2020 at 09:33:02PM +0530, Jagan Teki wrote:
> Adding display timings directly on device tree files make it difficult
> to maintain as a same copy of timings may exist on different files or
> panel-simple driver.
>
> We have a panel-simple driver for this particular usage so supporting
> on this driver will help to use the same timings on any device tree
> files if the board mounted on a similar vendor display.
>
> Engicam C.TOUCH OF 10.1" LCD board uses Ampire 10.1" TFT LCD and
> it has supported by panel-simple already, so simply use that binding.
>
> Signed-off-by: Jagan Teki <[email protected]>
Applied, thanks.