2020-10-19 17:32:00

by Tom Rix

Subject: [PATCH] iio: remove unneeded break

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

Signed-off-by: Tom Rix <[email protected]>
---
drivers/iio/adc/meson_saradc.c | 2 --
drivers/iio/imu/bmi160/bmi160_core.c | 1 -
2 files changed, 3 deletions(-)

diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
index e03988698755..66dc452d643a 100644
--- a/drivers/iio/adc/meson_saradc.c
+++ b/drivers/iio/adc/meson_saradc.c
@@ -593,13 +593,11 @@ static int meson_sar_adc_iio_info_read_raw(struct iio_dev *indio_dev,
case IIO_CHAN_INFO_RAW:
return meson_sar_adc_get_sample(indio_dev, chan, NO_AVERAGING,
ONE_SAMPLE, val);
- break;

case IIO_CHAN_INFO_AVERAGE_RAW:
return meson_sar_adc_get_sample(indio_dev, chan,
MEAN_AVERAGING, EIGHT_SAMPLES,
val);
- break;

case IIO_CHAN_INFO_SCALE:
if (chan->type == IIO_VOLTAGE) {
diff --git a/drivers/iio/imu/bmi160/bmi160_core.c b/drivers/iio/imu/bmi160/bmi160_core.c
index 222ebb26f013..431076dc0d2c 100644
--- a/drivers/iio/imu/bmi160/bmi160_core.c
+++ b/drivers/iio/imu/bmi160/bmi160_core.c
@@ -486,7 +486,6 @@ static int bmi160_write_raw(struct iio_dev *indio_dev,
case IIO_CHAN_INFO_SCALE:
return bmi160_set_scale(data,
bmi160_to_sensor(chan->type), val2);
- break;
case IIO_CHAN_INFO_SAMP_FREQ:
return bmi160_set_odr(data, bmi160_to_sensor(chan->type),
val, val2);
--
2.18.1

2020-10-21 17:37:48

by Martin Blumenstingl

Subject: Re: [PATCH] iio: remove unneeded break

On Mon, Oct 19, 2020 at 7:28 PM <[email protected]> wrote:
>
> From: Tom Rix <[email protected]>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/iio/adc/meson_saradc.c | 2 --
for meson_saradc.c:
Reviewed-by: Martin Blumenstingl <[email protected]>

2020-11-01 15:34:28

by Jonathan Cameron

Subject: Re: [PATCH] iio: remove unneeded break

On Tue, 20 Oct 2020 21:39:17 +0200
Martin Blumenstingl <[email protected]> wrote:

> On Mon, Oct 19, 2020 at 7:28 PM <[email protected]> wrote:
> >
> > From: Tom Rix <[email protected]>
> >
> > A break is not needed if it is preceded by a return
> >
> > Signed-off-by: Tom Rix <[email protected]>
> > ---
> > drivers/iio/adc/meson_saradc.c | 2 --
> for meson_saradc.c:
> Reviewed-by: Martin Blumenstingl <[email protected]>
Applied,

Thanks,

Jonathan