2020-10-31 21:10:56

by J. Neuschäfer

Subject: [PATCH] ARM: dts: imx50-kobo-aura: Add 'grp' suffix to pinctrl node names

i.MX pinctrl group nodes should have names that ends with 'grp'.

Reported-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Jonathan Neuschäfer <[email protected]>
---
arch/arm/boot/dts/imx50-kobo-aura.dts | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/arm/boot/dts/imx50-kobo-aura.dts b/arch/arm/boot/dts/imx50-kobo-aura.dts
index a0eaf869b9135..53b3995d37e7f 100644
--- a/arch/arm/boot/dts/imx50-kobo-aura.dts
+++ b/arch/arm/boot/dts/imx50-kobo-aura.dts
@@ -139,7 +139,7 @@ &i2c3 {
};

&iomuxc {
- pinctrl_gpiokeys: gpiokeys {
+ pinctrl_gpiokeys: gpiokeysgrp {
fsl,pins = <
MX50_PAD_CSPI_MISO__GPIO4_10 0x0
MX50_PAD_SD2_D7__GPIO5_15 0x0
@@ -147,34 +147,34 @@ MX50_PAD_KEY_ROW0__GPIO4_1 0x0
>;
};

- pinctrl_i2c1: i2c1 {
+ pinctrl_i2c1: i2c1grp {
fsl,pins = <
MX50_PAD_I2C1_SCL__I2C1_SCL 0x400001fd
MX50_PAD_I2C1_SDA__I2C1_SDA 0x400001fd
>;
};

- pinctrl_i2c2: i2c2 {
+ pinctrl_i2c2: i2c2grp {
fsl,pins = <
MX50_PAD_I2C2_SCL__I2C2_SCL 0x400001fd
MX50_PAD_I2C2_SDA__I2C2_SDA 0x400001fd
>;
};

- pinctrl_i2c3: i2c3 {
+ pinctrl_i2c3: i2c3grp {
fsl,pins = <
MX50_PAD_I2C3_SCL__I2C3_SCL 0x400001fd
MX50_PAD_I2C3_SDA__I2C3_SDA 0x400001fd
>;
};

- pinctrl_leds: leds {
+ pinctrl_leds: ledsgrp {
fsl,pins = <
MX50_PAD_PWM1__GPIO6_24 0x0
>;
};

- pinctrl_sd1: sd1 {
+ pinctrl_sd1: sd1grp {
fsl,pins = <
MX50_PAD_SD1_CMD__ESDHC1_CMD 0x1e4
MX50_PAD_SD1_CLK__ESDHC1_CLK 0xd4
@@ -187,7 +187,7 @@ MX50_PAD_SD2_CD__GPIO5_17 0x0
>;
};

- pinctrl_sd2: sd2 {
+ pinctrl_sd2: sd2grp {
fsl,pins = <
MX50_PAD_SD2_CMD__ESDHC2_CMD 0x1e4
MX50_PAD_SD2_CLK__ESDHC2_CLK 0xd4
@@ -198,19 +198,19 @@ MX50_PAD_SD2_D3__ESDHC2_DAT3 0x1d4
>;
};

- pinctrl_sd2_reset: sd2-reset {
+ pinctrl_sd2_reset: sd2-resetgrp {
fsl,pins = <
MX50_PAD_ECSPI2_MOSI__GPIO4_17 0x0
>;
};

- pinctrl_sd2_vmmc: sd2-vmmc {
+ pinctrl_sd2_vmmc: sd2-vmmcgrp {
fsl,pins = <
MX50_PAD_ECSPI1_SCLK__GPIO4_12 0x0
>;
};

- pinctrl_sd3: sd3 {
+ pinctrl_sd3: sd3grp {
fsl,pins = <
MX50_PAD_SD3_CMD__ESDHC3_CMD 0x1e4
MX50_PAD_SD3_CLK__ESDHC3_CLK 0xd4
@@ -225,14 +225,14 @@ MX50_PAD_SD3_D7__ESDHC3_DAT7 0x1d4
>;
};

- pinctrl_uart2: uart2 {
+ pinctrl_uart2: uart2grp {
fsl,pins = <
MX50_PAD_UART2_TXD__UART2_TXD_MUX 0x1e4
MX50_PAD_UART2_RXD__UART2_RXD_MUX 0x1e4
>;
};

- pinctrl_usbphy: usbphy {
+ pinctrl_usbphy: usbphygrp {
fsl,pins = <
MX50_PAD_ECSPI2_SS0__GPIO4_19 0x0
>;
--
2.28.0

2020-11-02 08:48:27

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: dts: imx50-kobo-aura: Add 'grp' suffix to pinctrl node names

On Sat, Oct 31, 2020 at 10:07:29PM +0100, Jonathan Neuschäfer wrote:
> i.MX pinctrl group nodes should have names that ends with 'grp'.
>
> Reported-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: Jonathan Neuschäfer <[email protected]>
> ---
> arch/arm/boot/dts/imx50-kobo-aura.dts | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2020-11-03 10:58:51

by Shawn Guo

Subject: Re: [PATCH] ARM: dts: imx50-kobo-aura: Add 'grp' suffix to pinctrl node names

On Sat, Oct 31, 2020 at 10:07:29PM +0100, Jonathan Neusch?fer wrote:
> i.MX pinctrl group nodes should have names that ends with 'grp'.
>
> Reported-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: Jonathan Neusch?fer <[email protected]>

Applied, thanks.