2020-10-31 18:30:25

by Paul Kocialkowski

[permalink] [raw]
Subject: [PATCH 4/9] dt-bindings: irq: sun7i-nmi: Add binding for the V3s NMI

The NMI interrupt controller takes a specific compatible for the V3s.
Add it to the device-tree bindings documentation.

Signed-off-by: Paul Kocialkowski <[email protected]>
---
.../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
index 8acca0ae3129..52364c2200ef 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
@@ -26,6 +26,7 @@ properties:
- const: allwinner,sun6i-a31-sc-nmi
deprecated: true
- const: allwinner,sun7i-a20-sc-nmi
+ - const: allwinner,sun8i-v3s-sc-nmi
- items:
- const: allwinner,sun8i-a83t-r-intc
- const: allwinner,sun6i-a31-r-intc
--
2.28.0


2020-11-02 10:11:45

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH 4/9] dt-bindings: irq: sun7i-nmi: Add binding for the V3s NMI

On Sat, Oct 31, 2020 at 07:21:32PM +0100, Paul Kocialkowski wrote:
> The NMI interrupt controller takes a specific compatible for the V3s.

Why?

> Add it to the device-tree bindings documentation.
>
> Signed-off-by: Paul Kocialkowski <[email protected]>
> ---
> .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
> index 8acca0ae3129..52364c2200ef 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
> @@ -26,6 +26,7 @@ properties:
> - const: allwinner,sun6i-a31-sc-nmi
> deprecated: true
> - const: allwinner,sun7i-a20-sc-nmi
> + - const: allwinner,sun8i-v3s-sc-nmi

This should be sorted

Maxime

Attachments:
(No filename) (1.02 kB)
 signature.asc (235.00 B)
 Download all attachments

2020-11-02 10:18:49

by Paul Kocialkowski

[permalink] [raw]
Subject: Re: [PATCH 4/9] dt-bindings: irq: sun7i-nmi: Add binding for the V3s NMI

Hi,

On Mon 02 Nov 20, 11:09, Maxime Ripard wrote:
> On Sat, Oct 31, 2020 at 07:21:32PM +0100, Paul Kocialkowski wrote:
> > The NMI interrupt controller takes a specific compatible for the V3s.
>
> Why?

Well, it's explained in details in the patch adding support in the driver
and in less details when adding the dt nodes. But okay I'll add a short
explanation here as well :)

> > Add it to the device-tree bindings documentation.
> >
> > Signed-off-by: Paul Kocialkowski <[email protected]>
> > ---
> > .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
> > index 8acca0ae3129..52364c2200ef 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
> > @@ -26,6 +26,7 @@ properties:
> > - const: allwinner,sun6i-a31-sc-nmi
> > deprecated: true
> > - const: allwinner,sun7i-a20-sc-nmi
> > + - const: allwinner,sun8i-v3s-sc-nmi
>
> This should be sorted

Ah sorry. So this should be between allwinner,sun8i-a83t-r-intc
and allwinner,sun9i-a80-nmi then.

--
Developer of free digital technology and hardware support.

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/