LinuxLists.cc - [PATCH 0/2] drivers/tty: delete break after return

2020-11-04 06:35:20

Subject: [PATCH 0/2] drivers/tty: delete break after return

This patch sereies delete break after return, which will never run.

Signed-off-by: Bernard Zhao <[email protected]>
*** BLURB HERE ***

Bernard Zhao (2):
drivers/tty: delete break after return
drivers/tty: delete break after return

drivers/tty/nozomi.c | 4 ----
drivers/tty/serial/imx.c | 5 -----
2 files changed, 9 deletions(-)

--
2.29.0

2020-11-04 06:35:27

by 赵军奎

[permalink] [raw]

Subject: [PATCH 1/2] drivers/tty: delete break after return

Delete break after return, which will never run.

Signed-off-by: Bernard Zhao <[email protected]>
---
drivers/tty/nozomi.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
index d42b854cb7df..946cc16827aa 100644
--- a/drivers/tty/nozomi.c
+++ b/drivers/tty/nozomi.c
@@ -414,11 +414,9 @@ static void read_mem32(u32 *buf, const void __iomem *mem_addr_start,
buf16 = (u16 *) buf;
*buf16 = __le16_to_cpu(readw(ptr));
goto out;
- break;
case 4: /* 4 bytes */
*(buf) = __le32_to_cpu(readl(ptr));
goto out;
- break;
}

while (i < size_bytes) {
@@ -460,7 +458,6 @@ static u32 write_mem32(void __iomem *mem_addr_start, const u32 *buf,
buf16 = (const u16 *)buf;
writew(__cpu_to_le16(*buf16), ptr);
return 2;
- break;
case 1: /*
* also needs to write 4 bytes in this case
* so falling through..
@@ -468,7 +465,6 @@ static u32 write_mem32(void __iomem *mem_addr_start, const u32 *buf,
case 4: /* 4 bytes */
writel(__cpu_to_le32(*buf), ptr);
return 4;
- break;
}

while (i < size_bytes) {
--
2.29.0

2020-11-04 06:35:30

by 赵军奎

[permalink] [raw]

Subject: [PATCH 2/2] drivers/tty: delete break after return

Delete break after return, which will never run.

Signed-off-by: Bernard Zhao <[email protected]>
---
drivers/tty/serial/imx.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 1731d9728865..09703079db7b 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -320,7 +320,6 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset)
switch (offset) {
case UCR1:
return sport->ucr1;
- break;
case UCR2:
/*
* UCR2_SRST is the only bit in the cached registers that might
@@ -331,16 +330,12 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset)
if (!(sport->ucr2 & UCR2_SRST))
sport->ucr2 = readl(sport->port.membase + offset);
return sport->ucr2;
- break;
case UCR3:
return sport->ucr3;
- break;
case UCR4:
return sport->ucr4;
- break;
case UFCR:
return sport->ufcr;
- break;
default:
return readl(sport->port.membase + offset);
}
--
2.29.0

2020-11-04 06:35:42

by 赵军奎

[permalink] [raw]

Subject: [PATCH 0/2] drivers/tty: delete break after return

2020-11-04 06:36:27

by 赵军奎

[permalink] [raw]

Subject: [PATCH 1/2] drivers/tty: delete break after return

2020-11-04 06:36:34

by 赵军奎

[permalink] [raw]

Subject: [PATCH 2/2] drivers/tty: delete break after return

2020-11-04 06:51:37

by Greg Kroah-Hartman

[permalink] [raw]

Subject: Re: [PATCH 0/2] drivers/tty: delete break after return

On Tue, Nov 03, 2020 at 10:33:22PM -0800, Bernard Zhao wrote:
> This patch sereies delete break after return, which will never run.
>
> Signed-off-by: Bernard Zhao <[email protected]>
> *** BLURB HERE ***

No blurb?

>
> Bernard Zhao (2):
> drivers/tty: delete break after return
> drivers/tty: delete break after return

You sent different patches, doing different things, yet they have the
same subject lines? That's not acceptable, sorry. Please fix up and
resend a new version of this series.

Also, you sent 4 patches, not 2.

thanks,

greg k-h