2020-11-04 09:33:33

by Xu Wang

Subject: [PATCH] media: i2c: mt9p031: Remove redundant null check before clk_disable_unprepare

Because clk_disable_unprepare() already checked NULL clock parameter,
so the additional check is unnecessary, just remove it.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/media/i2c/mt9p031.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
index dc23b9ed510a..a633b934d93e 100644
--- a/drivers/media/i2c/mt9p031.c
+++ b/drivers/media/i2c/mt9p031.c
@@ -346,8 +346,7 @@ static void mt9p031_power_off(struct mt9p031 *mt9p031)
regulator_bulk_disable(ARRAY_SIZE(mt9p031->regulators),
mt9p031->regulators);

- if (mt9p031->clk)
- clk_disable_unprepare(mt9p031->clk);
+ clk_disable_unprepare(mt9p031->clk);
}

static int __mt9p031_set_power(struct mt9p031 *mt9p031, bool on)
--
2.17.1

2020-11-05 03:16:47

by Laurent Pinchart

Subject: Re: [PATCH] media: i2c: mt9p031: Remove redundant null check before clk_disable_unprepare

Hi Xu Wang,

Thank you for the patch.

On Wed, Nov 04, 2020 at 09:29:48AM +0000, Xu Wang wrote:
> Because clk_disable_unprepare() already checked NULL clock parameter,
> so the additional check is unnecessary, just remove it.
>
> Signed-off-by: Xu Wang <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

I expect Sakari will pick this patch.

> ---
> drivers/media/i2c/mt9p031.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
> index dc23b9ed510a..a633b934d93e 100644
> --- a/drivers/media/i2c/mt9p031.c
> +++ b/drivers/media/i2c/mt9p031.c
> @@ -346,8 +346,7 @@ static void mt9p031_power_off(struct mt9p031 *mt9p031)
> regulator_bulk_disable(ARRAY_SIZE(mt9p031->regulators),
> mt9p031->regulators);
>
> - if (mt9p031->clk)
> - clk_disable_unprepare(mt9p031->clk);
> + clk_disable_unprepare(mt9p031->clk);
> }
>
> static int __mt9p031_set_power(struct mt9p031 *mt9p031, bool on)

--
Regards,

Laurent Pinchart