2020-11-04 18:23:00

by Coiby Xu

Subject: [PATCH 1/4] pinctrl: amd: fix incorrect way to disable debounce filter

The correct way to disable debounce filter is to clear bit 5 and 6
of the register.

Cc: Hans de Goede <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Coiby Xu <[email protected]>
---
drivers/pinctrl/pinctrl-amd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 9a760f5cd7ed..d6b2b4bd337c 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -166,14 +166,14 @@ static int amd_gpio_set_debounce(struct gpio_chip *gc, unsigned offset,
pin_reg |= BIT(DB_TMR_OUT_UNIT_OFF);
pin_reg |= BIT(DB_TMR_LARGE_OFF);
} else {
- pin_reg &= ~DB_CNTRl_MASK;
+ pin_reg &= ~(DB_CNTRl_MASK << DB_CNTRL_OFF);
ret = -EINVAL;
}
} else {
pin_reg &= ~BIT(DB_TMR_OUT_UNIT_OFF);
pin_reg &= ~BIT(DB_TMR_LARGE_OFF);
pin_reg &= ~DB_TMR_OUT_MASK;
- pin_reg &= ~DB_CNTRl_MASK;
+ pin_reg &= ~(DB_CNTRl_MASK << DB_CNTRL_OFF);
}
writel(pin_reg, gpio_dev->base + offset * 4);
raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
--
2.28.0

2020-11-04 23:11:40

by Coiby Xu

Subject: Re: [PATCH 1/4] pinctrl: amd: fix incorrect way to disable debounce filter

On Wed, Nov 04, 2020 at 10:38:32PM +0200, Andy Shevchenko wrote:
>On Wed, Nov 4, 2020 at 6:05 PM Coiby Xu <[email protected]> wrote:
>>
>> The correct way to disable debounce filter is to clear bit 5 and 6
>> of the register.
>>
>> Cc: Hans de Goede <[email protected]>
>
>> Message-ID: <[email protected]>
>
>Can you use a Link tag with proper lore.kernel.org URL?
>
Thank you for the suggestion. Applied in v2.

>--
>With Best Regards,
>Andy Shevchenko

--
Best regards,
Coiby

2020-11-05 01:43:18

by Andy Shevchenko

Subject: Re: [PATCH 1/4] pinctrl: amd: fix incorrect way to disable debounce filter

On Wed, Nov 4, 2020 at 6:05 PM Coiby Xu <[email protected]> wrote:
>
> The correct way to disable debounce filter is to clear bit 5 and 6
> of the register.
>
> Cc: Hans de Goede <[email protected]>

> Message-ID: <[email protected]>

Can you use a Link tag with proper lore.kernel.org URL?

--
With Best Regards,
Andy Shevchenko