2020-11-04 16:06:50

by Coiby Xu

Subject: [PATCH 2/4] pinctrl: amd: use higher precision for 512 RtcClk

RTC is 32.768kHz thus 512 RtcClk equals to 15625 usec.

Reported-by: Andy Shevchenko <[email protected]>
Suggested-by: Andy Shevchenko <[email protected]>
Suggested-by: Hans de Goede <[email protected]>
Message-ID: <[email protected]>
Message-ID: <CAHp75VdYhe4YEAzULMNkhihTQwHAP3fC2F6iD=datqzyzd=4fQ@mail.gmail.com>
Signed-off-by: Coiby Xu <[email protected]>
---
drivers/pinctrl/pinctrl-amd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index d6b2b4bd337c..4aea3e05e8c6 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -156,7 +156,7 @@ static int amd_gpio_set_debounce(struct gpio_chip *gc, unsigned offset,
pin_reg |= BIT(DB_TMR_OUT_UNIT_OFF);
pin_reg &= ~BIT(DB_TMR_LARGE_OFF);
} else if (debounce < 250000) {
- time = debounce / 15600;
+ time = debounce / 15625;
pin_reg |= time & DB_TMR_OUT_MASK;
pin_reg &= ~BIT(DB_TMR_OUT_UNIT_OFF);
pin_reg |= BIT(DB_TMR_LARGE_OFF);
--
2.28.0

2020-11-04 21:18:15

by Andy Shevchenko

Subject: Re: [PATCH 2/4] pinctrl: amd: use higher precision for 512 RtcClk

On Wed, Nov 4, 2020 at 6:04 PM Coiby Xu <[email protected]> wrote:
>
> RTC is 32.768kHz thus 512 RtcClk equals to 15625 usec.

equals 15625

> Reported-by: Andy Shevchenko <[email protected]>
> Suggested-by: Andy Shevchenko <[email protected]>

One of them is enough.

> Suggested-by: Hans de Goede <[email protected]>
> Message-ID: <[email protected]>
> Message-ID: <CAHp75VdYhe4YEAzULMNkhihTQwHAP3fC2F6iD=datqzyzd=4fQ@mail.gmail.com>

Link: https://lore.kernel.org/...

And I guess one link to a head of discussion is enough.

--
With Best Regards,
Andy Shevchenko