2020-11-05 12:15:37

by Prabhakar Mahadev Lad

[permalink] [raw]
Subject: [PATCH] arm64: dts: renesas: hihope-rev4: Add a comment explaining switch SW2404 required for audio_clk_b

Switch SW2404 should be at poistion 1 so that clock output from CS2000
is connected to AUDIO_CLKB_A.

Signed-off-by: Lad Prabhakar <[email protected]>
Reviewed-by: Chris Paterson <[email protected]>
---
arch/arm64/boot/dts/renesas/hihope-rev4.dtsi | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi b/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi
index 3046c07a288b..929f4a1d3f90 100644
--- a/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi
@@ -91,7 +91,11 @@
#clock-cells = <1>;
clock-frequency = <12288000 11289600>;

- /* update <audio_clk_b> to <cs2000> */
+ /*
+ * Update <audio_clk_b> to <cs2000>
+ * Switch SW2404 should be at position 1 so that clock from
+ * CS2000 is connected to AUDIO_CLKB_A
+ */
clocks = <&cpg CPG_MOD 1005>,
<&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>,
<&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>,
--
2.17.1


2020-11-09 10:10:47

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: renesas: hihope-rev4: Add a comment explaining switch SW2404 required for audio_clk_b

On Thu, Nov 5, 2020 at 1:11 PM Lad Prabhakar
<[email protected]> wrote:
> Switch SW2404 should be at poistion 1 so that clock output from CS2000

position (will fix while applying).

> is connected to AUDIO_CLKB_A.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-devel for v5.11.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-11-09 10:15:33

by Prabhakar Mahadev Lad

[permalink] [raw]
Subject: RE: [PATCH] arm64: dts: renesas: hihope-rev4: Add a comment explaining switch SW2404 required for audio_clk_b

Hi Geert,

Thank you for the review.

> -----Original Message-----
> From: Geert Uytterhoeven <[email protected]>
> Sent: 09 November 2020 10:09
> To: Prabhakar Mahadev Lad <[email protected]>
> Cc: Magnus Damm <[email protected]>; Rob Herring <[email protected]>; Linux-Renesas <linux-
> [email protected]>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <[email protected]>; Linux Kernel Mailing List <[email protected]>; Prabhakar
> <[email protected]>
> Subject: Re: [PATCH] arm64: dts: renesas: hihope-rev4: Add a comment explaining switch SW2404 required
> for audio_clk_b
>
> On Thu, Nov 5, 2020 at 1:11 PM Lad Prabhakar
> <[email protected]> wrote:
> > Switch SW2404 should be at poistion 1 so that clock output from CS2000
>
> position (will fix while applying).
>
Argh, thank you for taking care of it.

Cheers,
Prabhakar

> > is connected to AUDIO_CLKB_A.
> >
> > Signed-off-by: Lad Prabhakar <[email protected]>
> > Reviewed-by: Chris Paterson <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
> i.e. will queue in renesas-devel for v5.11.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds