2020-11-02 20:38:58

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH v3 3/3] dt-bindings: panel: common: Add reference to graph schema

Now that we have a graph schema, reference it from the common panel
schema.

Cc: Thierry Reding <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Signed-off-by: Rob Herring <[email protected]>
---
v3: new patch

.../devicetree/bindings/display/panel/panel-common.yaml | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
index cd6dc5461721..a3a72c574213 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
@@ -68,16 +68,15 @@ properties:

# Connectivity
port:
- type: object
+ $ref: /schemas/graph.yaml#/properties/port

ports:
- type: object
+ $ref: /schemas/graph.yaml#/properties/ports
description:
Panels receive video data through one or multiple connections. While
the nature of those connections is specific to the panel type, the
connectivity is expressed in a standard fashion using ports as specified
- in the device graph bindings defined in
- Documentation/devicetree/bindings/graph.txt.
+ in the device graph bindings.

ddc-i2c-bus:
$ref: /schemas/types.yaml#/definitions/phandle
--
2.25.1


2020-11-05 21:49:25

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH v3 3/3] dt-bindings: panel: common: Add reference to graph schema

On Mon, Nov 02, 2020 at 02:36:56PM -0600, Rob Herring wrote:
> Now that we have a graph schema, reference it from the common panel
> schema.
>
> Cc: Thierry Reding <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>
Reviewed-by: Sam Ravnborg <[email protected]>

I expect you to apply the patch due to the dependencies.
We can start using graph.yaml in drm-misc-next after the merge
window and a backmerge.

Sam

2020-11-11 14:08:41

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH v3 3/3] dt-bindings: panel: common: Add reference to graph schema

Hi Rob,

Thank you for the patch.

On Mon, Nov 02, 2020 at 02:36:56PM -0600, Rob Herring wrote:
> Now that we have a graph schema, reference it from the common panel
> schema.
>
> Cc: Thierry Reding <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> v3: new patch
>
> .../devicetree/bindings/display/panel/panel-common.yaml | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> index cd6dc5461721..a3a72c574213 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> @@ -68,16 +68,15 @@ properties:
>
> # Connectivity
> port:
> - type: object
> + $ref: /schemas/graph.yaml#/properties/port
>
> ports:
> - type: object
> + $ref: /schemas/graph.yaml#/properties/ports
> description:
> Panels receive video data through one or multiple connections. While
> the nature of those connections is specific to the panel type, the
> connectivity is expressed in a standard fashion using ports as specified
> - in the device graph bindings defined in
> - Documentation/devicetree/bindings/graph.txt.
> + in the device graph bindings.
>
> ddc-i2c-bus:
> $ref: /schemas/types.yaml#/definitions/phandle

--
Regards,

Laurent Pinchart