2020-11-06 00:36:56

by Bhaumik Bhatt

Subject: [PATCH v1 5/6] bus: mhi: core: Rename RDDM download function to use proper words

mhi_download_rddm_img() uses a shorter version of the word image.
Expand it and rename the function to mhi_download_rddm_image().

Signed-off-by: Bhaumik Bhatt <[email protected]>
---
drivers/bus/mhi/core/boot.c | 4 ++--
include/linux/mhi.h | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c
index 6b6fd96..16244cc 100644
--- a/drivers/bus/mhi/core/boot.c
+++ b/drivers/bus/mhi/core/boot.c
@@ -147,7 +147,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
}

/* Download RDDM image from device */
-int mhi_download_rddm_img(struct mhi_controller *mhi_cntrl, bool in_panic)
+int mhi_download_rddm_image(struct mhi_controller *mhi_cntrl, bool in_panic)
{
void __iomem *base = mhi_cntrl->bhie;
struct device *dev = &mhi_cntrl->mhi_dev->dev;
@@ -169,7 +169,7 @@ int mhi_download_rddm_img(struct mhi_controller *mhi_cntrl, bool in_panic)

return (rx_status == BHIE_RXVECSTATUS_STATUS_XFER_COMPL) ? 0 : -EIO;
}
-EXPORT_SYMBOL_GPL(mhi_download_rddm_img);
+EXPORT_SYMBOL_GPL(mhi_download_rddm_image);

static int mhi_fw_load_amss(struct mhi_controller *mhi_cntrl,
const struct mhi_buf *mhi_buf)
diff --git a/include/linux/mhi.h b/include/linux/mhi.h
index 9225d55..52b3c60 100644
--- a/include/linux/mhi.h
+++ b/include/linux/mhi.h
@@ -645,12 +645,12 @@ int mhi_pm_suspend(struct mhi_controller *mhi_cntrl);
int mhi_pm_resume(struct mhi_controller *mhi_cntrl);

/**
- * mhi_download_rddm_img - Download ramdump image from device for
- * debugging purpose.
+ * mhi_download_rddm_image - Download ramdump image from device for
+ * debugging purpose.
* @mhi_cntrl: MHI controller
* @in_panic: Download rddm image during kernel panic
*/
-int mhi_download_rddm_img(struct mhi_controller *mhi_cntrl, bool in_panic);
+int mhi_download_rddm_image(struct mhi_controller *mhi_cntrl, bool in_panic);

/**
* mhi_force_rddm_mode - Force device into rddm mode
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2020-11-06 05:35:44

by Manivannan Sadhasivam

Subject: Re: [PATCH v1 5/6] bus: mhi: core: Rename RDDM download function to use proper words

On Thu, Nov 05, 2020 at 04:34:28PM -0800, Bhaumik Bhatt wrote:
> mhi_download_rddm_img() uses a shorter version of the word image.
> Expand it and rename the function to mhi_download_rddm_image().
>
> Signed-off-by: Bhaumik Bhatt <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
> drivers/bus/mhi/core/boot.c | 4 ++--
> include/linux/mhi.h | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c
> index 6b6fd96..16244cc 100644
> --- a/drivers/bus/mhi/core/boot.c
> +++ b/drivers/bus/mhi/core/boot.c
> @@ -147,7 +147,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
> }
>
> /* Download RDDM image from device */
> -int mhi_download_rddm_img(struct mhi_controller *mhi_cntrl, bool in_panic)
> +int mhi_download_rddm_image(struct mhi_controller *mhi_cntrl, bool in_panic)
> {
> void __iomem *base = mhi_cntrl->bhie;
> struct device *dev = &mhi_cntrl->mhi_dev->dev;
> @@ -169,7 +169,7 @@ int mhi_download_rddm_img(struct mhi_controller *mhi_cntrl, bool in_panic)
>
> return (rx_status == BHIE_RXVECSTATUS_STATUS_XFER_COMPL) ? 0 : -EIO;
> }
> -EXPORT_SYMBOL_GPL(mhi_download_rddm_img);
> +EXPORT_SYMBOL_GPL(mhi_download_rddm_image);
>
> static int mhi_fw_load_amss(struct mhi_controller *mhi_cntrl,
> const struct mhi_buf *mhi_buf)
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 9225d55..52b3c60 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -645,12 +645,12 @@ int mhi_pm_suspend(struct mhi_controller *mhi_cntrl);
> int mhi_pm_resume(struct mhi_controller *mhi_cntrl);
>
> /**
> - * mhi_download_rddm_img - Download ramdump image from device for
> - * debugging purpose.
> + * mhi_download_rddm_image - Download ramdump image from device for
> + * debugging purpose.
> * @mhi_cntrl: MHI controller
> * @in_panic: Download rddm image during kernel panic
> */
> -int mhi_download_rddm_img(struct mhi_controller *mhi_cntrl, bool in_panic);
> +int mhi_download_rddm_image(struct mhi_controller *mhi_cntrl, bool in_panic);
>
> /**
> * mhi_force_rddm_mode - Force device into rddm mode
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>