2020-11-03 14:30:03

by Joel Fernandes

Subject: [PATCH v9 5/7] rcu/segcblist: Remove useless rcupdate.h include

Signed-off-by: Joel Fernandes (Google) <[email protected]>
---
kernel/rcu/rcu_segcblist.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c
index 2a03949d0b82..e9e72d72f7a6 100644
--- a/kernel/rcu/rcu_segcblist.c
+++ b/kernel/rcu/rcu_segcblist.c
@@ -10,7 +10,6 @@
#include <linux/cpu.h>
#include <linux/interrupt.h>
#include <linux/kernel.h>
-#include <linux/rcupdate.h>
#include <linux/types.h>

#include "rcu_segcblist.h"
--
2.29.1.341.ge80a0c044ae-goog

2020-11-05 06:37:31

by Paul E. McKenney

Subject: Re: [PATCH v9 5/7] rcu/segcblist: Remove useless rcupdate.h include

On Tue, Nov 03, 2020 at 09:26:01AM -0500, Joel Fernandes (Google) wrote:
> Signed-off-by: Joel Fernandes (Google) <[email protected]>

This one looks fine, but depends on the earlier "rcu/segcblist: Add
counters to segcblist datastructure" patch, which also changes the list
of #include directives for this file. It manages to avoid conflicting
with "rcu/trace: Add tracing for how segcb list changes", despite this
one also changing the #include directives.

I am testing it just out of curiosity, but it might make more sense
to fold this one into "rcu/segcblist: Add counters to segcblist
datastructure".

Thanx, Paul

> ---
> kernel/rcu/rcu_segcblist.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c
> index 2a03949d0b82..e9e72d72f7a6 100644
> --- a/kernel/rcu/rcu_segcblist.c
> +++ b/kernel/rcu/rcu_segcblist.c
> @@ -10,7 +10,6 @@
> #include <linux/cpu.h>
> #include <linux/interrupt.h>
> #include <linux/kernel.h>
> -#include <linux/rcupdate.h>
> #include <linux/types.h>
>
> #include "rcu_segcblist.h"
> --
> 2.29.1.341.ge80a0c044ae-goog
>

2020-11-05 14:32:19

by Paul E. McKenney

Subject: Re: [PATCH v9 5/7] rcu/segcblist: Remove useless rcupdate.h include

On Wed, Nov 04, 2020 at 07:48:23PM -0800, Paul E. McKenney wrote:
> On Tue, Nov 03, 2020 at 09:26:01AM -0500, Joel Fernandes (Google) wrote:
> > Signed-off-by: Joel Fernandes (Google) <[email protected]>
>
> This one looks fine, but depends on the earlier "rcu/segcblist: Add
> counters to segcblist datastructure" patch, which also changes the list
> of #include directives for this file. It manages to avoid conflicting
> with "rcu/trace: Add tracing for how segcb list changes", despite this
> one also changing the #include directives.
>
> I am testing it just out of curiosity, but it might make more sense
> to fold this one into "rcu/segcblist: Add counters to segcblist
> datastructure".

And it does pass light rcutorture. ;-)

Thanx, Paul

> > ---
> > kernel/rcu/rcu_segcblist.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c
> > index 2a03949d0b82..e9e72d72f7a6 100644
> > --- a/kernel/rcu/rcu_segcblist.c
> > +++ b/kernel/rcu/rcu_segcblist.c
> > @@ -10,7 +10,6 @@
> > #include <linux/cpu.h>
> > #include <linux/interrupt.h>
> > #include <linux/kernel.h>
> > -#include <linux/rcupdate.h>
> > #include <linux/types.h>
> >
> > #include "rcu_segcblist.h"
> > --
> > 2.29.1.341.ge80a0c044ae-goog
> >

2020-11-07 00:30:50

by Joel Fernandes

Subject: Re: [PATCH v9 5/7] rcu/segcblist: Remove useless rcupdate.h include

On Thu, Nov 05, 2020 at 06:28:10AM -0800, Paul E. McKenney wrote:
> On Wed, Nov 04, 2020 at 07:48:23PM -0800, Paul E. McKenney wrote:
> > On Tue, Nov 03, 2020 at 09:26:01AM -0500, Joel Fernandes (Google) wrote:
> > > Signed-off-by: Joel Fernandes (Google) <[email protected]>
> >
> > This one looks fine, but depends on the earlier "rcu/segcblist: Add
> > counters to segcblist datastructure" patch, which also changes the list
> > of #include directives for this file. It manages to avoid conflicting
> > with "rcu/trace: Add tracing for how segcb list changes", despite this
> > one also changing the #include directives.
> >
> > I am testing it just out of curiosity, but it might make more sense
> > to fold this one into "rcu/segcblist: Add counters to segcblist
> > datastructure".
>
> And it does pass light rcutorture. ;-)

Cool, I squashed it into 2/7 and updated my tree.

thanks,

- Joel

> Thanx, Paul
>
> > > ---
> > > kernel/rcu/rcu_segcblist.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c
> > > index 2a03949d0b82..e9e72d72f7a6 100644
> > > --- a/kernel/rcu/rcu_segcblist.c
> > > +++ b/kernel/rcu/rcu_segcblist.c
> > > @@ -10,7 +10,6 @@
> > > #include <linux/cpu.h>
> > > #include <linux/interrupt.h>
> > > #include <linux/kernel.h>
> > > -#include <linux/rcupdate.h>
> > > #include <linux/types.h>
> > >
> > > #include "rcu_segcblist.h"
> > > --
> > > 2.29.1.341.ge80a0c044ae-goog
> > >