2020-11-09 11:52:16

by Zou Wei

Subject: [PATCH -next] cpumask: use false and true for bool variables

Fix coccicheck warnings:

./lib/cpumask.c:342:6-13: WARNING: Comparison of 0/1 to bool variable
./lib/cpumask.c:351:33-40: WARNING: Comparison of 0/1 to bool variable
./lib/cpumask.c:406:3-11: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
lib/cpumask.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/cpumask.c b/lib/cpumask.c
index 34ecb30..74d0cf1 100644
--- a/lib/cpumask.c
+++ b/lib/cpumask.c
@@ -339,7 +339,7 @@ static int find_nearest_node(int *node_dist, bool *used)

/* Choose the first unused node to compare */
for (i = 0; i < nr_node_ids; i++) {
- if (used[i] == 0) {
+ if (used[i] == false) {
min_dist = node_dist[i];
node_id = i;
break;
@@ -348,7 +348,7 @@ static int find_nearest_node(int *node_dist, bool *used)

/* Compare and return the nearest node */
for (i = 0; i < nr_node_ids; i++) {
- if (node_dist[i] < min_dist && used[i] == 0) {
+ if (node_dist[i] < min_dist && used[i] == false) {
min_dist = node_dist[i];
node_id = i;
}
@@ -403,7 +403,7 @@ unsigned int cpumask_local_spread(unsigned int i, int node)
flags);
return cpu;
}
- used[id] = 1;
+ used[id] = true;
}
spin_unlock_irqrestore(&spread_lock, flags);

--
2.6.2

2020-11-09 13:00:19

by Peter Zijlstra

Subject: Re: [PATCH -next] cpumask: use false and true for bool variables

On Mon, Nov 09, 2020 at 07:59:50PM +0800, Zou Wei wrote:
> Fix coccicheck warnings:
>
> ./lib/cpumask.c:342:6-13: WARNING: Comparison of 0/1 to bool variable
> ./lib/cpumask.c:351:33-40: WARNING: Comparison of 0/1 to bool variable
> ./lib/cpumask.c:406:3-11: WARNING: Assignment of 0/1 to bool variable

None of that is a problem, please, apply:

https://lkml.kernel.org/r/[email protected]

and go do something useful.

2020-11-09 13:47:30

by Paul Gortmaker

Subject: Re: [PATCH -next] cpumask: use false and true for bool variables

On 2020-11-09 6:59 a.m., Zou Wei wrote:
> Fix coccicheck warnings:
>
> ./lib/cpumask.c:342:6-13: WARNING: Comparison of 0/1 to bool variable
> ./lib/cpumask.c:351:33-40: WARNING: Comparison of 0/1 to bool variable
> ./lib/cpumask.c:406:3-11: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <[email protected]>

It seems "Hulk Robot" needs an AI "tune-up". I didn't touch any of
these lines of code - and I'm guessing they haven't changed in years.

Paul.
--

> Signed-off-by: Zou Wei <[email protected]>
> ---
> lib/cpumask.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/cpumask.c b/lib/cpumask.c
> index 34ecb30..74d0cf1 100644
> --- a/lib/cpumask.c
> +++ b/lib/cpumask.c
> @@ -339,7 +339,7 @@ static int find_nearest_node(int *node_dist, bool *used)
>
> /* Choose the first unused node to compare */
> for (i = 0; i < nr_node_ids; i++) {
> - if (used[i] == 0) {
> + if (used[i] == false) {
> min_dist = node_dist[i];
> node_id = i;
> break;
> @@ -348,7 +348,7 @@ static int find_nearest_node(int *node_dist, bool *used)
>
> /* Compare and return the nearest node */
> for (i = 0; i < nr_node_ids; i++) {
> - if (node_dist[i] < min_dist && used[i] == 0) {
> + if (node_dist[i] < min_dist && used[i] == false) {
> min_dist = node_dist[i];
> node_id = i;
> }
> @@ -403,7 +403,7 @@ unsigned int cpumask_local_spread(unsigned int i, int node)
> flags);
> return cpu;
> }
> - used[id] = 1;
> + used[id] = true;
> }
> spin_unlock_irqrestore(&spread_lock, flags);
>
>