2020-11-11 09:45:07

by Robin Hsu

[permalink] [raw]
Subject: [PATCH] f2fs-tools: skipped to end on error syntax error

From: Robin Hsu <[email protected]>

When error were found, we won't need to do any initialization but
just quit.

Signed-off-by: Robin Hsu <[email protected]>
---
fsck/main.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/fsck/main.c b/fsck/main.c
index 32559f1..e70048b 100644
--- a/fsck/main.c
+++ b/fsck/main.c
@@ -597,20 +597,22 @@ void f2fs_parse_options(int argc, char *argv[])
}
}

- add_default_options();
+ if (err == NOERROR) {
+ add_default_options();

- if (optind >= argc) {
- MSG(0, "\tError: Device not specified\n");
- error_out(prog);
- }
+ if (optind >= argc) {
+ MSG(0, "\tError: Device not specified\n");
+ error_out(prog);
+ }

- c.devices[0].path = strdup(argv[optind]);
- if (argc > (optind + 1)) {
- c.dbg_lv = 0;
- err = EUNKNOWN_ARG;
+ c.devices[0].path = strdup(argv[optind]);
+ if (argc > (optind + 1)) {
+ c.dbg_lv = 0;
+ err = EUNKNOWN_ARG;
+ }
+ if (err == NOERROR)
+ return;
}
- if (err == NOERROR)
- return;

/* print out error */
switch (err) {
--
2.29.2.222.g5d2a92d10f8-goog