2020-11-09 11:09:04

by Michael Walle

Subject: [PATCH net RESEND] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC

Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX") the
network port of the Kontron sl28 board is broken. After the migration to
phylink the device tree has to specify the in-band-mode property. Add
it.

Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
Suggested-by: Vladimir Oltean <[email protected]>
Signed-off-by: Michael Walle <[email protected]>
Reviewed-by: Vladimir Oltean <[email protected]>
---
Forgot to add the netdev@ mailinglist in my former submission.

From my previous mail:
> Ping. will this go through the net queue or Shawn's queue. In any case,
> it should make it into a fixes queue, because this board is currently
> broken in 5.10-rc2.

arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index 17a2f5dacc3f..54ff6f7c2477 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -79,6 +79,7 @@
&enetc_port0 {
phy-handle = <&phy0>;
phy-connection-type = "sgmii";
+ managed = "in-band-status";
status = "okay";

mdio {
--
2.20.1

2020-11-12 01:36:55

by Jakub Kicinski

Subject: Re: [PATCH net RESEND] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC

On Mon, 9 Nov 2020 12:04:36 +0100 Michael Walle wrote:
> Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX") the
> network port of the Kontron sl28 board is broken. After the migration to
> phylink the device tree has to specify the in-band-mode property. Add
> it.
>
> Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> Suggested-by: Vladimir Oltean <[email protected]>
> Signed-off-by: Michael Walle <[email protected]>
> Reviewed-by: Vladimir Oltean <[email protected]>

Applied to net, thanks!