2020-11-12 08:41:27

by Hsin-Yi Wang

Subject: [PATCH 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies

anx7625 requires 3 power supply regulators.

Signed-off-by: Hsin-Yi Wang <[email protected]>
---
.../display/bridge/analogix,anx7625.yaml | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 60585a4fc22b..1aa08f10d894 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -34,6 +34,18 @@ properties:
description: used for reset chip control, RESET_N pin B7.
maxItems: 1

+ vdd10-supply:
+ description: Regulator that provides the supply 1.0V power.
+ maxItems: 1
+
+ vdd18-supply:
+ description: Regulator that provides the supply 1.8V power.
+ maxItems: 1
+
+ vdd33-supply:
+ description: Regulator that provides the supply 3.3V power.
+ maxItems: 1
+
ports:
type: object

@@ -55,6 +67,9 @@ properties:
required:
- compatible
- reg
+ - vdd10-supply
+ - vdd18-supply
+ - vdd33-supply
- ports

additionalProperties: false
@@ -72,6 +87,9 @@ examples:
reg = <0x58>;
enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
+ vdd10-supply = <&pp1000_mipibrdg>;
+ vdd18-supply = <&pp1800_mipibrdg>;
+ vdd33-supply = <&pp3300_mipibrdg>;

ports {
#address-cells = <1>;
--
2.29.2.222.g5d2a92d10f8-goog

2020-11-13 02:39:13

by Xin Ji

Subject: Re: [PATCH 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies

On Thu, Nov 12, 2020 at 04:37:03PM +0800, Hsin-Yi Wang wrote:
> anx7625 requires 3 power supply regulators.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> ---
> .../display/bridge/analogix,anx7625.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>

Reviewed-by: Xin Ji <[email protected]>

2020-11-21 12:55:12

by Rob Herring (Arm)

Subject: Re: [PATCH 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies

On Thu, Nov 12, 2020 at 04:37:03PM +0800, Hsin-Yi Wang wrote:
> anx7625 requires 3 power supply regulators.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> ---
> .../display/bridge/analogix,anx7625.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 60585a4fc22b..1aa08f10d894 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -34,6 +34,18 @@ properties:
> description: used for reset chip control, RESET_N pin B7.
> maxItems: 1
>
> + vdd10-supply:
> + description: Regulator that provides the supply 1.0V power.
> + maxItems: 1
> +
> + vdd18-supply:
> + description: Regulator that provides the supply 1.8V power.
> + maxItems: 1
> +
> + vdd33-supply:
> + description: Regulator that provides the supply 3.3V power.
> + maxItems: 1

Supplies are always a single item, so you can drop maxItems.

> +
> ports:
> type: object
>
> @@ -55,6 +67,9 @@ properties:
> required:
> - compatible
> - reg
> + - vdd10-supply
> + - vdd18-supply
> + - vdd33-supply
> - ports
>
> additionalProperties: false
> @@ -72,6 +87,9 @@ examples:
> reg = <0x58>;
> enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> + vdd10-supply = <&pp1000_mipibrdg>;
> + vdd18-supply = <&pp1800_mipibrdg>;
> + vdd33-supply = <&pp3300_mipibrdg>;
>
> ports {
> #address-cells = <1>;
> --
> 2.29.2.222.g5d2a92d10f8-goog
>