2020-11-03 11:50:02

by Zou Wei

Subject: [PATCH -next] IB/isert: Fix warning Comparison to bool

Fix below warning reported by coccicheck:

./ib_isert.c:1104:12-24: WARNING: Comparison to bool

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/infiniband/ulp/isert/ib_isert.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index bd47894..e47cd02 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -1101,7 +1101,7 @@ isert_handle_scsi_cmd(struct isert_conn *isert_conn,
sequence_cmd:
rc = iscsit_sequence_cmd(conn, cmd, buf, hdr->cmdsn);

- if (!rc && dump_payload == false && unsol_data)
+ if (!rc && !dump_payload && unsol_data)
iscsit_set_unsolicited_dataout(cmd);
else if (dump_payload && imm_data)
target_put_sess_cmd(&cmd->se_cmd);
--
2.6.2

2020-11-03 20:21:06

by Sagi Grimberg

Subject: Re: [PATCH -next] IB/isert: Fix warning Comparison to bool

Reviewed-by: Sagi Grimberg <[email protected]>

2020-11-12 16:43:28

by Jason Gunthorpe

Subject: Re: [PATCH -next] IB/isert: Fix warning Comparison to bool

On Tue, Nov 03, 2020 at 07:57:54PM +0800, Zou Wei wrote:
> Fix below warning reported by coccicheck:
>
> ./ib_isert.c:1104:12-24: WARNING: Comparison to bool
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> Reviewed-by: Sagi Grimberg <[email protected]>
> ---
> drivers/infiniband/ulp/isert/ib_isert.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason