2020-11-13 15:59:32

by Laurent Vivier

Subject: [PATCH] vdpasim: fix "mac_pton" undefined error

ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!

mac_pton() is defined in lib/net_utils.c and is not built if NET is not set.

Select GENERIC_NET_UTILS as vdpasim doesn't depend on NET.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Laurent Vivier <[email protected]>
---
drivers/vdpa/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
index d7d32b656102..358f6048dd3c 100644
--- a/drivers/vdpa/Kconfig
+++ b/drivers/vdpa/Kconfig
@@ -13,6 +13,7 @@ config VDPA_SIM
depends on RUNTIME_TESTING_MENU && HAS_DMA
select DMA_OPS
select VHOST_RING
+ select GENERIC_NET_UTILS
default n
help
vDPA networking device simulator which loop TX traffic back
--
2.28.0

2020-11-13 18:51:37

by Randy Dunlap

Subject: Re: [PATCH] vdpasim: fix "mac_pton" undefined error

On 11/13/20 7:57 AM, Laurent Vivier wrote:
> ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
>
> mac_pton() is defined in lib/net_utils.c and is not built if NET is not set.
>
> Select GENERIC_NET_UTILS as vdpasim doesn't depend on NET.
>
> Reported-by: kernel test robot <[email protected]>

On Nov. 2, 2020:

Reported-by: Randy Dunlap <[email protected]>

https://lore.kernel.org/lkml/[email protected]/


> Signed-off-by: Laurent Vivier <[email protected]>
> ---
> drivers/vdpa/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
> index d7d32b656102..358f6048dd3c 100644
> --- a/drivers/vdpa/Kconfig
> +++ b/drivers/vdpa/Kconfig
> @@ -13,6 +13,7 @@ config VDPA_SIM
> depends on RUNTIME_TESTING_MENU && HAS_DMA
> select DMA_OPS
> select VHOST_RING
> + select GENERIC_NET_UTILS
> default n
> help
> vDPA networking device simulator which loop TX traffic back
>

Thanks for the patch.

--
~Randy

2020-11-13 19:36:16

by Randy Dunlap

Subject: Re: [PATCH] vdpasim: fix "mac_pton" undefined error

On 11/13/20 10:49 AM, Randy Dunlap wrote:
> On 11/13/20 7:57 AM, Laurent Vivier wrote:
>> ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
>>
>> mac_pton() is defined in lib/net_utils.c and is not built if NET is not set.
>>
>> Select GENERIC_NET_UTILS as vdpasim doesn't depend on NET.
>>
>> Reported-by: kernel test robot <[email protected]>
>
> On Nov. 2, 2020:
>
> Reported-by: Randy Dunlap <[email protected]>
>
> https://lore.kernel.org/lkml/[email protected]/
>
>
>> Signed-off-by: Laurent Vivier <[email protected]>
>> ---
>> drivers/vdpa/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
>> index d7d32b656102..358f6048dd3c 100644
>> --- a/drivers/vdpa/Kconfig
>> +++ b/drivers/vdpa/Kconfig
>> @@ -13,6 +13,7 @@ config VDPA_SIM
>> depends on RUNTIME_TESTING_MENU && HAS_DMA
>> select DMA_OPS
>> select VHOST_RING
>> + select GENERIC_NET_UTILS
>> default n
>> help
>> vDPA networking device simulator which loop TX traffic back
>>
>
> Thanks for the patch.

Acked-by: Randy Dunlap <[email protected]> # build-tested

--
~Randy