2020-11-13 09:29:18

by Antoine Tenart

Subject: Re: [PATCH net v2] net: phy: mscc: remove non-MACSec compatible phy

Quoting Steen Hegelund (2020-11-13 10:11:16)
> Selecting VSC8575 as a MACSec PHY was not correct
>
> The relevant datasheet can be found here:
> - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575
>
> History:
> v1 -> v2:
> - Corrected the sha in the "Fixes:" tag
>
> Fixes: 1bbe0ecc2a1a ("net: phy: mscc: macsec initialization")
> Signed-off-by: Steen Hegelund <[email protected]>

Reviewed-by: Antoine Tenart <[email protected]>

Small comment: you can put the commit history after the --- so it
doesn't end-up in the commit log (except when it's relevant, which isn't
the case here). I don't think that's a blocker though.

Thanks Steen!
Antoine

> ---
> drivers/net/phy/mscc/mscc_macsec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/phy/mscc/mscc_macsec.c b/drivers/net/phy/mscc/mscc_macsec.c
> index 1d4c012194e9..72292bf6c51c 100644
> --- a/drivers/net/phy/mscc/mscc_macsec.c
> +++ b/drivers/net/phy/mscc/mscc_macsec.c
> @@ -981,7 +981,6 @@ int vsc8584_macsec_init(struct phy_device *phydev)
>
> switch (phydev->phy_id & phydev->drv->phy_id_mask) {
> case PHY_ID_VSC856X:
> - case PHY_ID_VSC8575:
> case PHY_ID_VSC8582:
> case PHY_ID_VSC8584:
> INIT_LIST_HEAD(&vsc8531->macsec_flows);
> --
> 2.29.2
>

2020-11-14 00:19:17

by Jakub Kicinski

Subject: Re: [PATCH net v2] net: phy: mscc: remove non-MACSec compatible phy

On Fri, 13 Nov 2020 09:27:30 +0000 Antoine Tenart wrote:
> Quoting Steen Hegelund (2020-11-13 10:11:16)
> > Selecting VSC8575 as a MACSec PHY was not correct
> >
> > The relevant datasheet can be found here:
> > - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575
> >
> > History:
> > v1 -> v2:
> > - Corrected the sha in the "Fixes:" tag
> >
> > Fixes: 1bbe0ecc2a1a ("net: phy: mscc: macsec initialization")
> > Signed-off-by: Steen Hegelund <[email protected]>
>
> Reviewed-by: Antoine Tenart <[email protected]>

Applied, thanks!