2020-11-13 22:43:28

by Maximilian Luz

Subject: [PATCH] platform/surface: gpe: Add support for 15" Intel version of Surface Laptop 3

In addition to a 13" version, there is also a 15" (business) version of
the Surface Laptop 3 based on Intel CPUs. This version also handles
wakeup by lid via (unmarked) GPEs, so add support for it as well.

Signed-off-by: Maximilian Luz <[email protected]>
---
drivers/platform/surface/surface_gpe.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c
index 0f44a52d3a9b..e49e5d6d5d4e 100644
--- a/drivers/platform/surface/surface_gpe.c
+++ b/drivers/platform/surface/surface_gpe.c
@@ -146,6 +146,18 @@ static const struct dmi_system_id dmi_lid_device_table[] = {
},
.driver_data = (void *)lid_device_props_l4D,
},
+ {
+ .ident = "Surface Laptop 3 (Intel 15\")",
+ .matches = {
+ /*
+ * We match for SKU here due to different variants: The
+ * AMD (15") version does not rely on GPEs.
+ */
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "Surface_Laptop_3_1872"),
+ },
+ .driver_data = (void *)lid_device_props_l4D,
+ },
{ }
};

--
2.29.2

2020-11-24 12:14:53

by Hans de Goede

Subject: Re: [PATCH] platform/surface: gpe: Add support for 15" Intel version of Surface Laptop 3

Hi,

On 11/13/20 11:39 PM, Maximilian Luz wrote:
> In addition to a 13" version, there is also a 15" (business) version of
> the Surface Laptop 3 based on Intel CPUs. This version also handles
> wakeup by lid via (unmarked) GPEs, so add support for it as well.
>
> Signed-off-by: Maximilian Luz <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
> drivers/platform/surface/surface_gpe.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c
> index 0f44a52d3a9b..e49e5d6d5d4e 100644
> --- a/drivers/platform/surface/surface_gpe.c
> +++ b/drivers/platform/surface/surface_gpe.c
> @@ -146,6 +146,18 @@ static const struct dmi_system_id dmi_lid_device_table[] = {
> },
> .driver_data = (void *)lid_device_props_l4D,
> },
> + {
> + .ident = "Surface Laptop 3 (Intel 15\")",
> + .matches = {
> + /*
> + * We match for SKU here due to different variants: The
> + * AMD (15") version does not rely on GPEs.
> + */
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "Surface_Laptop_3_1872"),
> + },
> + .driver_data = (void *)lid_device_props_l4D,
> + },
> { }
> };
>
>