2020-11-15 08:32:31

by Wangshaobo (bobo)

Subject: [PATCH] IB/hfi1: Fix error return code in hfi1_init_dd()

Fix to return the error code from hfi1_netdev_alloc() instaed of 0
in hfi1_init_dd(), as done elsewhere in this function.

Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev")
Signed-off-by: Wang ShaoBo <[email protected]>
---
drivers/infiniband/hw/hfi1/chip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/hfi1/chip.c b/drivers/infiniband/hw/hfi1/chip.c
index 7eaf99538216..c87b94ea2939 100644
--- a/drivers/infiniband/hw/hfi1/chip.c
+++ b/drivers/infiniband/hw/hfi1/chip.c
@@ -15245,7 +15245,8 @@ int hfi1_init_dd(struct hfi1_devdata *dd)
& CCE_REVISION_SW_MASK);

/* alloc netdev data */
- if (hfi1_netdev_alloc(dd))
+ ret = hfi1_netdev_alloc(dd);
+ if (ret)
goto bail_cleanup;

ret = set_up_context_variables(dd);
--
2.25.1

2020-11-15 12:50:39

by Leon Romanovsky

Subject: Re: [PATCH] IB/hfi1: Fix error return code in hfi1_init_dd()

On Sun, Nov 15, 2020 at 04:25:48PM +0800, Wang ShaoBo wrote:
> Fix to return the error code from hfi1_netdev_alloc() instaed of 0
> in hfi1_init_dd(), as done elsewhere in this function.
>
> Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev")
> Signed-off-by: Wang ShaoBo <[email protected]>
> ---
> drivers/infiniband/hw/hfi1/chip.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

It was already handled, thanks
https://lore.kernel.org/lkml/[email protected]