2020-11-09 09:22:07

by Lukas Bulwahn

Subject: [PATCH] MAINTAINERS: rectify file patterns for NETFILTER

The two file patterns in the NETFILTER section:

F: include/linux/netfilter*
F: include/uapi/linux/netfilter*

intended to match the directories:

./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}

A quick check with ./scripts/get_maintainer.pl --letters -f will show that
they are not matched, though, because this pattern only matches files, but
not directories.

Rectify the patterns to match the intended directories.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
applies cleanly on v5.10-rc3 and next-20201109

Pablo, Jozsef, Florian, please pick this minor non-urgent clean-up patch.

MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index cba8ddf87a08..572a064a9c95 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12139,10 +12139,10 @@ W: http://www.nftables.org/
Q: http://patchwork.ozlabs.org/project/netfilter-devel/list/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
T: git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git
-F: include/linux/netfilter*
+F: include/linux/netfilter*/
F: include/linux/netfilter/
F: include/net/netfilter/
-F: include/uapi/linux/netfilter*
+F: include/uapi/linux/netfilter*/
F: include/uapi/linux/netfilter/
F: net/*/netfilter.c
F: net/*/netfilter/
--
2.17.1

2020-11-15 11:23:52

by Pablo Neira Ayuso

Subject: Re: [PATCH] MAINTAINERS: rectify file patterns for NETFILTER

On Mon, Nov 09, 2020 at 10:19:42AM +0100, Lukas Bulwahn wrote:
> The two file patterns in the NETFILTER section:
>
> F: include/linux/netfilter*
> F: include/uapi/linux/netfilter*
>
> intended to match the directories:
>
> ./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}
>
> A quick check with ./scripts/get_maintainer.pl --letters -f will show that
> they are not matched, though, because this pattern only matches files, but
> not directories.
>
> Rectify the patterns to match the intended directories.

Applied, thanks.

2020-11-16 04:16:07

by Joe Perches

Subject: Re: [PATCH] MAINTAINERS: rectify file patterns for NETFILTER

On Mon, 2020-11-09 at 10:19 +0100, Lukas Bulwahn wrote:
> The two file patterns in the NETFILTER section:
>
> ??F: include/linux/netfilter*
> ??F: include/uapi/linux/netfilter*
>
> intended to match the directories:
>
> ??./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}
>
> A quick check with ./scripts/get_maintainer.pl --letters -f will show that
> they are not matched, though, because this pattern only matches files, but
> not directories.
>
> Rectify the patterns to match the intended directories.
[]
diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -12139,10 +12139,10 @@ W: http://www.nftables.org/
> ?Q: http://patchwork.ozlabs.org/project/netfilter-devel/list/
> ?T: git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
> ?T: git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git
> -F: include/linux/netfilter*
> +F: include/linux/netfilter*/
> ?F: include/linux/netfilter/

This line could be deleted or perhaps moved up one line above

F: include/linux/netfilter/
F: include/linux/netfilter*/

(as the second line already matches the first line's files too)

> ?F: include/net/netfilter/
> -F: include/uapi/linux/netfilter*
> +F: include/uapi/linux/netfilter*/
> ?F: include/uapi/linux/netfilter/

same here.

> ?F: net/*/netfilter.c
> ?F: net/*/netfilter/

2020-11-17 01:44:24

by Pablo Neira Ayuso

Subject: Re: [PATCH] MAINTAINERS: rectify file patterns for NETFILTER

Hi Lukas,

On Sun, Nov 15, 2020 at 07:58:33PM -0800, Joe Perches wrote:
> On Mon, 2020-11-09 at 10:19 +0100, Lukas Bulwahn wrote:
> > The two file patterns in the NETFILTER section:
> >
> >   F: include/linux/netfilter*
> >   F: include/uapi/linux/netfilter*
> >
> > intended to match the directories:
> >
> >   ./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}
> >
> > A quick check with ./scripts/get_maintainer.pl --letters -f will show that
> > they are not matched, though, because this pattern only matches files, but
> > not directories.
> >
> > Rectify the patterns to match the intended directories.
> []
> diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -12139,10 +12139,10 @@ W: http://www.nftables.org/
> >  Q: http://patchwork.ozlabs.org/project/netfilter-devel/list/
> >  T: git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
> >  T: git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git
> > -F: include/linux/netfilter*
> > +F: include/linux/netfilter*/
> >  F: include/linux/netfilter/
>
> This line could be deleted or perhaps moved up one line above
>
> F: include/linux/netfilter/
> F: include/linux/netfilter*/
>
> (as the second line already matches the first line's files too)
>
> >  F: include/net/netfilter/
> > -F: include/uapi/linux/netfilter*
> > +F: include/uapi/linux/netfilter*/
> >  F: include/uapi/linux/netfilter/
>
> same here.
>
> >  F: net/*/netfilter.c
> >  F: net/*/netfilter/

Please, send a v2 to address this feedback. Thank you.