2020-11-16 09:46:04

by Tiezhu Yang

[permalink] [raw]
Subject: [PATCH] Documentation: kgdb: Fix a typo

"to into" -> "into"

Reported-by: Sergei Shtylyov <[email protected]>
Signed-off-by: Tiezhu Yang <[email protected]>
---
Documentation/dev-tools/kgdb.rst | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
index 77b688e..4345624 100644
--- a/Documentation/dev-tools/kgdb.rst
+++ b/Documentation/dev-tools/kgdb.rst
@@ -63,10 +63,9 @@ will want to turn on ``CONFIG_DEBUG_INFO`` which is called
It is advised, but not required, that you turn on the
``CONFIG_FRAME_POINTER`` kernel option which is called :menuselection:`Compile
the kernel with frame pointers` in the config menu. This option inserts code
-to into the compiled executable which saves the frame information in
-registers or on the stack at different points which allows a debugger
-such as gdb to more accurately construct stack back traces while
-debugging the kernel.
+into the compiled executable which saves the frame information in registers
+or on the stack at different points which allows a debugger such as gdb to
+more accurately construct stack back traces while debugging the kernel.

If the architecture that you are using supports the kernel option
``CONFIG_STRICT_KERNEL_RWX``, you should consider turning it off. This
--
2.1.0


2020-11-16 09:51:21

by Daniel Thompson

[permalink] [raw]
Subject: Re: [PATCH] Documentation: kgdb: Fix a typo

On Mon, Nov 16, 2020 at 05:42:47PM +0800, Tiezhu Yang wrote:
> "to into" -> "into"
>
> Reported-by: Sergei Shtylyov <[email protected]>
> Signed-off-by: Tiezhu Yang <[email protected]>

Acked-by: Daniel Thompson <[email protected]>


> ---
> Documentation/dev-tools/kgdb.rst | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
> index 77b688e..4345624 100644
> --- a/Documentation/dev-tools/kgdb.rst
> +++ b/Documentation/dev-tools/kgdb.rst
> @@ -63,10 +63,9 @@ will want to turn on ``CONFIG_DEBUG_INFO`` which is called
> It is advised, but not required, that you turn on the
> ``CONFIG_FRAME_POINTER`` kernel option which is called :menuselection:`Compile
> the kernel with frame pointers` in the config menu. This option inserts code
> -to into the compiled executable which saves the frame information in
> -registers or on the stack at different points which allows a debugger
> -such as gdb to more accurately construct stack back traces while
> -debugging the kernel.
> +into the compiled executable which saves the frame information in registers
> +or on the stack at different points which allows a debugger such as gdb to
> +more accurately construct stack back traces while debugging the kernel.
>
> If the architecture that you are using supports the kernel option
> ``CONFIG_STRICT_KERNEL_RWX``, you should consider turning it off. This
> --
> 2.1.0
>

2020-11-18 20:50:32

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] Documentation: kgdb: Fix a typo

On Mon, 16 Nov 2020 17:42:47 +0800
Tiezhu Yang <[email protected]> wrote:

> "to into" -> "into"
>
> Reported-by: Sergei Shtylyov <[email protected]>
> Signed-off-by: Tiezhu Yang <[email protected]>
> ---
> Documentation/dev-tools/kgdb.rst | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
> index 77b688e..4345624 100644
> --- a/Documentation/dev-tools/kgdb.rst
> +++ b/Documentation/dev-tools/kgdb.rst
> @@ -63,10 +63,9 @@ will want to turn on ``CONFIG_DEBUG_INFO`` which is called
> It is advised, but not required, that you turn on the
> ``CONFIG_FRAME_POINTER`` kernel option which is called :menuselection:`Compile
> the kernel with frame pointers` in the config menu. This option inserts code
> -to into the compiled executable which saves the frame information in
> -registers or on the stack at different points which allows a debugger
> -such as gdb to more accurately construct stack back traces while
> -debugging the kernel.
> +into the compiled executable which saves the frame information in registers
> +or on the stack at different points which allows a debugger such as gdb to
> +more accurately construct stack back traces while debugging the kernel.

Applied.

In the future, though, please avoid refilling paragraphs when you make a
change like this; it makes it much harder to see what has actually changed.

Thanks,

jon