Subject: [PATCH] (v2) drivers: clk: make gpio-gated clock support optional

The gpio-gate-clock / gpio-mux-clock driver isn't used much,
just by a few ARM SoCs, so there's no need to always include
it unconditionally.

Thus make it optional, but keep it enabled by default.

fixes v2: added missing dependency on gpiolib

Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
---
drivers/clk/Kconfig | 8 ++++++++
drivers/clk/Makefile | 2 +-
2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index c715d4681a0b..99e0188a15be 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -38,6 +38,14 @@ menuconfig COMMON_CLK

if COMMON_CLK

+config COMMON_CLK_GPIO
+ tristate "GPIO gated clock support"
+ default y
+ select gpiolib
+ help
+ Supports gpio gated clocks, which can be enabled/disabled via
+ gpio output.
+
config COMMON_CLK_WM831X
tristate "Clock driver for WM831x/2x PMICs"
depends on MFD_WM831X
diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
index da8fcf147eb1..0692ab5abc6d 100644
--- a/drivers/clk/Makefile
+++ b/drivers/clk/Makefile
@@ -11,7 +11,7 @@ obj-$(CONFIG_COMMON_CLK) += clk-multiplier.o
obj-$(CONFIG_COMMON_CLK) += clk-mux.o
obj-$(CONFIG_COMMON_CLK) += clk-composite.o
obj-$(CONFIG_COMMON_CLK) += clk-fractional-divider.o
-obj-$(CONFIG_COMMON_CLK) += clk-gpio.o
+obj-$(CONFIG_COMMON_CLK_GPIO) += clk-gpio.o
ifeq ($(CONFIG_OF), y)
obj-$(CONFIG_COMMON_CLK) += clk-conf.o
endif
--
2.11.0


2020-11-18 01:46:05

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] (v2) drivers: clk: make gpio-gated clock support optional

Quoting Enrico Weigelt, metux IT consult (2020-11-17 08:03:06)
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index c715d4681a0b..99e0188a15be 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -38,6 +38,14 @@ menuconfig COMMON_CLK
>
> if COMMON_CLK
>
> +config COMMON_CLK_GPIO
> + tristate "GPIO gated clock support"
> + default y

Maybe 'default GPIOLIB'?

> + select gpiolib

Does lowercase work here?

> + help
> + Supports gpio gated clocks, which can be enabled/disabled via
> + gpio output.
> +
> config COMMON_CLK_WM831X
> tristate "Clock driver for WM831x/2x PMICs"
> depends on MFD_WM831X

Subject: Re: [PATCH] (v2) drivers: clk: make gpio-gated clock support optional

On 18.11.20 02:42, Stephen Boyd wrote:
> Quoting Enrico Weigelt, metux IT consult (2020-11-17 08:03:06)
>> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
>> index c715d4681a0b..99e0188a15be 100644
>> --- a/drivers/clk/Kconfig
>> +++ b/drivers/clk/Kconfig
>> @@ -38,6 +38,14 @@ menuconfig COMMON_CLK
>>
>> if COMMON_CLK
>>
>> +config COMMON_CLK_GPIO
>> + tristate "GPIO gated clock support"
>> + default y
>
> Maybe 'default GPIOLIB'?
>
>> + select gpiolib
>
> Does lowercase work here?
>
>> + help
>> + Supports gpio gated clocks, which can be enabled/disabled via
>> + gpio output.
>> +
>> config COMMON_CLK_WM831X
>> tristate "Clock driver for WM831x/2x PMICs"
>> depends on MFD_WM831X


thanks, fixed it in v3.


BTW: just accidentially posted an outdated and broken version again
(some submit helper script was running wild :() - please ignore that.
the valid one is v3 from yesterday. sorry for the noise.


--mtx

--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
[email protected] -- +49-151-27565287