2020-11-17 16:23:28

by Sekhar Nori

[permalink] [raw]
Subject: [PATCH v2 0/4] arm64: dts: ti: J7200 GPIO support and warning fixes

These patches add gpio support for TI's J7200 platform. The first
two patches fix existing warnings in preparation for adding GPIO
support.

Changes in v2:
- Add patches fixing existing warnings so GPIO support does not
end up adding more warnings
- Addressed Nishanth's comments on GPIO patches
- merge patches adding main and wakeup domain GPIOs into single patch
- fix commit description going over 75 chars
- fix W=2 warnings about lack of #address-cells in GPIO nodes

Faiz Abbas (2):
arm64: dts: ti: k3-j7200: Add gpio nodes
arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio
modules

Sekhar Nori (2):
arm64: dts: ti: k3: squelch warning about lack of #interrupt-cells
arm64: dts: ti: k3: squelch warnings regarding no #address-cells for
interrupt-controller

arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 6 ++
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +
.../arm64/boot/dts/ti/k3-am654-base-board.dts | 1 +
.../dts/ti/k3-j7200-common-proc-board.dts | 16 ++++
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 75 +++++++++++++++++++
.../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 35 +++++++++
.../dts/ti/k3-j721e-common-proc-board.dts | 1 +
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 12 +++
.../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 3 +
9 files changed, 151 insertions(+)

--
2.17.1


2020-11-17 16:25:00

by Sekhar Nori

[permalink] [raw]
Subject: [PATCH v2 4/4] arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio modules

From: Faiz Abbas <[email protected]>

There are 6 gpio instances inside SoC with 2 groups as show below:
Group one: wkup_gpio0, wkup_gpio1
Group two: main_gpio0, main_gpio2, main_gpio4, main_gpio6

Only one instance from each group can be used at a time. So use main_gpio0
and wkup_gpio0 in current linux context and disable the rest of the nodes.

Signed-off-by: Faiz Abbas <[email protected]>
Signed-off-by: Sekhar Nori <[email protected]>
---
.../boot/dts/ti/k3-j7200-common-proc-board.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
index ef03e7636b66..0bc4170225d5 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
@@ -127,6 +127,22 @@
status = "disabled";
};

+&main_gpio2 {
+ status = "disabled";
+};
+
+&main_gpio4 {
+ status = "disabled";
+};
+
+&main_gpio6 {
+ status = "disabled";
+};
+
+&wkup_gpio1 {
+ status = "disabled";
+};
+
&mcu_cpsw {
pinctrl-names = "default";
pinctrl-0 = <&mcu_cpsw_pins_default &mcu_mdio_pins_default>;
--
2.17.1

2020-11-19 11:23:05

by Grygorii Strashko

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] arm64: dts: ti: J7200 GPIO support and warning fixes



On 17/11/2020 18:19, Sekhar Nori wrote:
> These patches add gpio support for TI's J7200 platform. The first
> two patches fix existing warnings in preparation for adding GPIO
> support.
>
> Changes in v2:
> - Add patches fixing existing warnings so GPIO support does not
> end up adding more warnings
> - Addressed Nishanth's comments on GPIO patches
> - merge patches adding main and wakeup domain GPIOs into single patch
> - fix commit description going over 75 chars
> - fix W=2 warnings about lack of #address-cells in GPIO nodes


>
> Faiz Abbas (2):
> arm64: dts: ti: k3-j7200: Add gpio nodes
> arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio
> modules
>
> Sekhar Nori (2):
> arm64: dts: ti: k3: squelch warning about lack of #interrupt-cells
> arm64: dts: ti: k3: squelch warnings regarding no #address-cells for
> interrupt-controller
>
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 6 ++
> arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +
> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 1 +
> .../dts/ti/k3-j7200-common-proc-board.dts | 16 ++++
> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 75 +++++++++++++++++++
> .../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 35 +++++++++
> .../dts/ti/k3-j721e-common-proc-board.dts | 1 +
> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 12 +++
> .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 3 +
> 9 files changed, 151 insertions(+)
>

For patches 1,3,4
Reviewed-by: Grygorii Strashko <[email protected]>
--
Best regards,
grygorii